Re: [PATCH] Modernize and improve test scripts `dist*.test'.

[Ralf Wildenhues]

* Stefano Lattarini wrote on Wed, Jul 21, 2010 at 09:47:43PM CEST:
> At Wednesday 21 July 2010, Ralf Wildenhues wrote:
> > * Stefano Lattarini wrote on Sat, Jun 19, 2010 at 09:34:34PM CEST:
> > > Yet another testsuite-tweaking patch.
> > 
> > OK for maint with nits below addressed.
> > 
> > > Modernize and improve test scripts `dist*.test'.
> > > 
> 
> > > * tests/distname.test: Add gunzip to $required.
> > Let's not add gunzip to $required (I think we discussed this before
> > for another patch).
> Yes, but this patch was written before that one :-)
> Fixed; BTW, is it ok to use `gzip -d' instead of `gunzip', as done in 
> e.g. `lib/am/distdir.am'? This is what I've done in the amended patch.

OK for maint if it rebases and tests without trouble.

> > This ok, but it could also be a function extract_make_var in
> > defs.in that takes a variable name in $1 and files in $2 etc., and
> > use that everywhere.
> I thought about that, but I prefer to leave it for a later patch 
> series aimed at refactoring defs.in.
> > You can then also replace ${1+"$@"} with
> > "$@" here.  If you want to make this change, it is preapproved
> > (just post the patch you commit).
> I'd rather leave it as it is for the moment; is that ok with you?

Sure.

Thanks,
Ralf