automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Modernize, improve and/or extend tests `colon*.test.


From: Stefano Lattarini
Subject: Re: [PATCH] Modernize, improve and/or extend tests `colon*.test.
Date: Sun, 8 Aug 2010 17:48:58 +0200
User-agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; )

At Sunday 08 August 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Sun, Aug 08, 2010 at 05:35:57PM CEST:
> > I'm just saying that when we'll write the `extract_makefile_deps'
> > function, it shouldn't bother with preserving tabs and
> > backslashes;
> 
> Well, it should deal with them correctly, yes.
> 
> > on the other hand, it should actively normalize them to space in
> > order to simplify grepping and matching of the extracted info.
> 
> I think we violently agree.
> 
> > So that, with your example below, something like:
> >   foo=`extract_makefile_deps tgt2 Makefile`; echo x"$foo"x
> > 
> > should print:
> >   x dep1 dep2 dep3 dep4 x
> 
> More or less, yes.  I'd avoid the command substitution fork by
> letting extract_makefile_deps set some variable instead of
> printing.
So the we'd have move the comamnd substitution inside the function? 
;-)
 
> > Have I managed to make my point now?  If yes, what do you think
> > of my proposal?
> 
> Good.
OK, it's mostly settled then.  I'm saving a ref to this message, for 
when we'll really implement extract_makefile_deps.

Thanks,
  Stefano



reply via email to

[Prev in Thread] Current Thread [Next in Thread]