[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Modernize, improve and extend tests `subobj*.test'.
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH] Modernize, improve and extend tests `subobj*.test'. |
Date: |
Sun, 8 Aug 2010 12:53:14 +0200 |
User-agent: |
Mutt/1.5.20 (2010-04-22) |
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 12:44:32PM CEST:
> At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > > -$FGREP 'generic/a.$(OBJEXT)' Makefile.in
> > > +grep '^generic/a\.\$(OBJEXT):' Makefile.in
> >
> > Some day I'll add initial and trailing space to the target names of
> > all generated rules to see how portable our test suite is ... ;-)
> I assume the change is OK, though... is it?
Are you trying to resurrect the discussion about whether tests should
exploit internal details more than necessary? We've been there before,
I think.
> > > -cat > foo/Makefile.am << 'EOF'
> > > +cat > foo/Makefile.am << 'END'
> > >
> > > AUTOMAKE_OPTIONS = subdir-objects
> > > bin_PROGRAMS = mumble
> > > mumble_SOURCES = bar/a.c
> > >
> > > -EOF
> > > +END
> >
> > Another one of those needless changes.
> It is to enhance consistency within the test script... should I revert
> it nonetheless?
I don't really care. In my very humble opinion, such questions take
time that could be used more productively on Automake development.
> Also, what about squashing in this additiona change, to avoid a
> useless fork (and a useless involution)?
Sure.
Cheers,
Ralf