Re: [PATCH] Handle odd winepath failures.

[Peter Rosin]

Den 2010-09-07 23:14 skrev Ralf Wildenhues:
> * Peter Rosin wrote on Tue, Aug 31, 2010 at 09:36:15PM CEST:
>> Den 2010-08-31 18:57 skrev Ralf Wildenhues:
>>> * Peter Rosin wrote on Tue, Aug 31, 2010 at 06:47:24PM CEST:
>>>> Subject: [PATCH] Handle odd winepath failures.
>>>>
>>>> * lib/ar-lib (func_file_conv): winepath can exit with zero exit
>>>> status but empty result, and can return a basically unconverted
>>>> path, but prefixed with \\?\unix. Treat both of these as failure
>>>> and retain the original file name.
>>>> * lib/compile (func_file_conv): Likewise.
>>>> Suggested by Ralf Wildenhues after reports of similar problems
>>>> elsewhere from Charles Wilson and Roumen Petrov.
>>>
>>> OK for msvc if you update $scriptversion in both scripts and add a test
>>> case.  Ideally two, one that is effective only on systems with wine
>>> installed and ensures that the output file name is not empty, the other
>>> one can fake, extending ar-lib.test.
>>
>> That will have to wait then, because I can't test with real Wine easily
>> ATM...
> 
> Can you create a test without testing it?  Someone else could do that
> for you.  It's probably good enough even to have a stricter than
> necessary test: as long as we know the intended coverage, we can always
> fixup test failures later.

I have bigger fish to fry at the moment. Wine users will have to wait a
bit...

Cheers,
Peter