automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] Work around a bug in Solaris make's file-inclusion mechan


From: Stefano Lattarini
Subject: Re: [PATCH v2] Work around a bug in Solaris make's file-inclusion mechanism.
Date: Wed, 15 Sep 2010 21:25:14 +0200
User-agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; )

Hi Ralf.  Thanks for the review.

On Wednesday 15 September 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Wed, Sep 15, 2010 at 01:26:50PM CEST:
> > OK for maint?
> 
> I really think you should use an extra function normalize_file_name
> to do the job, for maintainability.
> 
> 
> I don't think we want subobj11c.test.  What we want instead, and I
> agree with your earlier sentiments on this, is unit testing for the
> normalize_file_name function.  Which suggests that it should be in
> lib/Automake/FileUtils.pm I guess, and the test below
> lib/Automake/tests.  ;-)
> 
> If you need help, I can give more hints.  In case you're fed up,
> I can also do the rest, eventually.
I'm a little fed up with this in fact, but if you don't insist I have 
do the follow-up soon (which I bet you won't ;-), I think I can manage 
to give it a try eventually.

Regards,
   Stefano



reply via email to

[Prev in Thread] Current Thread [Next in Thread]