Re: [SIMPLE PATCHES] {maint} Minor improvements to maintainer checks

[Ralf Wildenhues]

* Stefano Lattarini wrote on Thu, Sep 16, 2010 at 01:14:46PM CEST:
> OK for maint?

The first one is ok with nit below addressed.

The second one seems too ad-hoc and maintenance-intensive
(we should strive for code that needs as little maintenance
as possible), I'd rather beat your patches in shape so they
don't need extra treatment.  ;-)

Thanks,
Ralf

> [PATCH 1/2] New maintainer check, for typos in $required definition.
> 
> * Makefile.am (sc_tests_required_typos): New maintaner check.
> (syntax_check_rules): Updated.
> From a report by Peter Rosin.

> [PATCH 2/2] Fix some spurious maintainer-check failures (exit vs. 
> Exit).
> 
> * Makefile.am (sc_tests_Exit_not_exit): Fixed spurious failures,
> and other minor improvements.

> @@ -358,6 +359,14 @@ sc_tests_plain_perl:
>         exit 1; \
>       fi
>  
> +## Look for common typos in the definition of `$required'.
> +sc_tests_required_typos:
> +     @if grep -v '^#' $(srcdir)/tests/*.test | grep -E '\brequires?='; then \

\b is not defined in Posix (SuSv3) ERE; see the respective autoconf.texi
text for egrep.  You can use (^|[^a-zA-Z0-9_]) instead.

> +       echo 'In the above tests, to declare required tools, you want' 1>&2; \
> +       echo 'to define $$required, not $$require or $$requires' 1>&2; \
> +       exit 1; \
> +     fi


> Subject: [PATCH 2/2] Fix some spurious maintainer-check failures (exit vs. 
> Exit).
> 
> * Makefile.am (sc_tests_Exit_not_exit): Fixed spurious failures,
> and other minor improvements.