[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] dist-xz: don't hard-code -9: honor setting of XZ_OPT
From: |
Stefano Lattarini |
Subject: |
Re: [PATCH] dist-xz: don't hard-code -9: honor setting of XZ_OPT |
Date: |
Tue, 5 Oct 2010 12:32:28 +0200 |
User-agent: |
KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) |
On Monday 04 October 2010, Jim Meyering wrote:
> Stefano Lattarini wrote:
> ...
>
> >> > BZIP2 environment variable
> >> >
> >> >> +For example, @samp{make dist-bzip2 XZ_OPT=-7}.
> >> >
> >> > Ditto.
> >>
> >> Thank you. Fixed.
> >
> > Hmm... thinking better, since we are dealing with environment
> >
> > variables here, shouldn't the correct idiom be:
> > $ BZIP2="-7" make dist-bzip2
> >
> > instead? Or am I missing something?
>
> Either way is fine with me.
Sorry for the noise, I thought that:
$ make FOO=1
wouldn't export `FOO' in the environment of the commands spawned by
make recipes (*blush*). But this is not the case, so I definitely
prefer your idiom now (make dist-bzip2 XZ_OPT=-7).
Thanks,
Stefano
- [PATCH] dist-xz: don't hard-code -9: honor setting of XZ_OPT, Jim Meyering, 2010/10/03
- Re: [PATCH] dist-xz: don't hard-code -9: honor setting of XZ_OPT, Ralf Wildenhues, 2010/10/03
- Re: [PATCH] dist-xz: don't hard-code -9: honor setting of XZ_OPT, Jim Meyering, 2010/10/03
- Re: [PATCH] dist-xz: don't hard-code -9: honor setting of XZ_OPT, Ralf Wildenhues, 2010/10/03
- Re: [PATCH] dist-xz: don't hard-code -9: honor setting of XZ_OPT, Jim Meyering, 2010/10/04
- Re: [PATCH] dist-xz: don't hard-code -9: honor setting of XZ_OPT, Stefano Lattarini, 2010/10/04
- Re: [PATCH] dist-xz: don't hard-code -9: honor setting of XZ_OPT, Jim Meyering, 2010/10/04
- Re: [PATCH] dist-xz: don't hard-code -9: honor setting of XZ_OPT, Stefano Lattarini, 2010/10/04
- Re: [PATCH] dist-xz: don't hard-code -9: honor setting of XZ_OPT, Jim Meyering, 2010/10/04
- Re: [PATCH] dist-xz: don't hard-code -9: honor setting of XZ_OPT,
Stefano Lattarini <=
- Re: [PATCH] dist-xz: don't hard-code -9: honor setting of XZ_OPT, Ralf Wildenhues, 2010/10/05
- Re: [PATCH] dist-xz: don't hard-code -9: honor setting of XZ_OPT, Jim Meyering, 2010/10/05
- Re: [PATCH] dist-xz: don't hard-code -9: honor setting of XZ_OPT, Lasse Collin, 2010/10/04
- Re: [PATCH] dist-xz: don't hard-code -9: honor setting of XZ_OPT, Ralf Wildenhues, 2010/10/11
- Re: [PATCH] dist-xz: don't hard-code -9: honor setting of XZ_OPT, Lasse Collin, 2010/10/11