Re: [PATCH] compile: clear the `eat' variable earlier.

[Stefano Lattarini]

On Monday 15 November 2010, Peter Rosin wrote:
> Den 2010-11-15 10:40 skrev Peter Rosin:
> > Den 2010-11-15 10:33 skrev Peter Rosin:
> >> Hi!
> >>
> >> I found this little gem in compile while reading the code.  Pushed as
> >> obvious to the msvc branch.
> > 
> > Obviously I tripped up while committing something obvious.  Sorry for
> > being sloppy.  So, I also pushed this follow-up commit to the msvc branch:
> > 
> > From d164eb55a41ec2fc48b402b276749f4b7d72dc91 Mon Sep 17 00:00:00 2001
> > From: Peter Rosin <address@hidden>
> > Date: Mon, 15 Nov 2010 10:37:26 +0100
> > Subject: [PATCH 2/2] lib/compile: update scriptversion.
> > 
> > Signed-off-by: Peter Rosin <address@hidden>
> > ---
> >  ChangeLog   |    2 ++
> >  lib/compile |    2 +-
> >  2 files changed, 3 insertions(+), 1 deletions(-)
> > 
> > diff --git a/ChangeLog b/ChangeLog
> > index 5e326d1..e091340 100644
> > --- a/ChangeLog
> > +++ b/ChangeLog
> > @@ -1,5 +1,7 @@
> >  2010-11-15  Peter Rosin  <address@hidden>
> >  
> > +   lib/compile: update scriptversion.
> > +
> 
> There's a couple of missing asterisks in the commit message.  Obviously.
> 
> Should I fixup the ChangeLog entry?
I'd say just to merge the "update scriptversion" message with the
previous entry in the ChangeLog, like this:

+2010-11-15  Peter Rosin  <address@hidden>
+
+       compile: clear the `eat' variable earlier.
+       * lib/compile: Clear the `eat' variable earlier.
+       ($scriptversion): Update.
+       * tests/compile3.test: Prevent regressions.
+

since the two commits are strictly consecutive anyway.

I can do that if it's OK for you.

Regards,
   Stefano