[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: tests: work around dash quoting issue in case statements.
From: |
Eric Blake |
Subject: |
Re: tests: work around dash quoting issue in case statements. |
Date: |
Mon, 15 Nov 2010 09:11:46 -0700 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101103 Fedora/1.0-0.33.b2pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.6 |
On 11/14/2010 10:24 AM, Ralf Wildenhues wrote:
> tests: work around dash quoting issue in case statements.
>
> * tests/color.test, tests/color2.test: Quote variable in case
> pattern, to avoid skipping tests with dash 0.5.5.1.
>
> diff --git a/tests/color.test b/tests/color.test
> index 9d86785..c1032fd 100755
> --- a/tests/color.test
> +++ b/tests/color.test
> @@ -34,7 +34,7 @@ std='[m'
> # BSD 'grep' works from a pipe, but not a seekable file.
> # GNU or BSD 'grep -a' works on files, but is not portable.
> case `echo "$std" | grep .` in
> - $std) ;;
> + "$std") ;;
I don't see this documented in the autoconf manual; would you care to
extend the existing documentation on case to mention this limitation?
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature