automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Improve and extend tests `pluseq*.test' (on `+=' support).


From: Ralf Wildenhues
Subject: Re: [PATCH] Improve and extend tests `pluseq*.test' (on `+=' support).
Date: Fri, 10 Dec 2010 20:13:14 +0100
User-agent: Mutt/1.5.20 (2010-08-04)

* Stefano Lattarini wrote on Fri, Dec 10, 2010 at 06:59:44PM CET:
> On Friday 10 December 2010, Ralf Wildenhues wrote:
> > * Stefano Lattarini wrote on Tue, Dec 07, 2010 at 11:42:35AM CET:
> > > -cat >> configure.in << 'END'
> > > -AC_SUBST([ZZZ])
> > > -END
> > 
> > OK, now we're plainly in oscillation land.  In a prior patch, you added
> > this code,
> >
> No I didn't, I just "normalized" it to be more consistent w.r.t. other
> testcases; in fact I just
>   - preferred cat over echo to create input files, and
>   - used proper m4 quoting.
> No semantic changes were done to the code in question back then.
> (I wasn't even thinking about them).

Ugh.  So now I managed to make a complete fool of myself with this
review.  Sorry about that.  I can only blame it on the lack of coffee
this morning, and promise a better one on Sunday ...

Cheers,
Ralf



reply via email to

[Prev in Thread] Current Thread [Next in Thread]