automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/2] Tests initialization: put default definition of AC_CONFI


From: Ralf Wildenhues
Subject: Re: [PATCH 0/2] Tests initialization: put default definition of AC_CONFIG_AUX_DIR in the pre-populated configure.in.
Date: Mon, 13 Dec 2010 20:17:48 +0100
User-agent: Mutt/1.5.20 (2010-08-04)

* Stefano Lattarini wrote on Sat, Dec 11, 2010 at 02:52:18PM CET:
> This is a reproposal of an older patch of mine:
>  <http://lists.gnu.org/archive/html/automake-patches/2010-05/msg00008.html>
>  <http://lists.gnu.org/archive/html/automake-patches/2010-05/msg00009.html>

> I see that some tests explicitly put a call like:
>   AC_CONFIG_AUX_DIR([.])
> in the generated configure.in, to prevent automake from looking into
> `..' and `../..' when trying to copy required files.
> 
> I think that such a provision should be made unconditional, as it could
> help to reduce undefined/unexpected behaviours.  Obviously, we should
> leave a way for the individual testcases to easily override this default
> (and some existing tests already require such an overriding).

I'm undecided on this one.  On the one hand, the safety increase is a
plus, but on the other hand, the tests become less readable, if only
because it is less obvious what is going on.  If you don't remember,
you have to start reading the generated configure.in file after
rerunning the test with keep_testdirs=:.

Hmm.  There is precedent with the 'parallel_tests' settings, but even
that looks unobvious to me, just like those actions triggered by a
'required' setting other than "is this test run or not".

What's the unexpected behavior we have to expect here?  (Sorry for the
pun.)

Then there's the spelling different AUX_DIR vs auxdir.

Cheers,
Ralf



reply via email to

[Prev in Thread] Current Thread [Next in Thread]