automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Test `$(var:suf=rpl)' expansion in special automake variable


From: Ralf Wildenhues
Subject: Re: [PATCH] Test `$(var:suf=rpl)' expansion in special automake variables.
Date: Sat, 18 Dec 2010 12:37:50 +0100
User-agent: Mutt/1.5.20 (2010-08-04)

* Stefano Lattarini wrote on Sat, Dec 18, 2010 at 10:35:43AM CET:
> On Saturday 18 December 2010, Ralf Wildenhues wrote:
> > > +# Try also with `:=', to ensure the parser is not unduly confused
> > > +# into thinking that it's an unportable assignement operator.
> > 
> > This comment is bogus, right?  There is no such thing as ':=' within
> > $(var:A=B),
> but there is in $(var:=x) (below this is "$(t1:=.sh)").
> 
> > and the code below does not use := to assign variables.
> >
> Indeed, and so we want to enssure the automake parser does not 
> (errenously) think we are trying to do so.
> 
> > What do you mean with this text?  "Also try an empty match suffix."?
> >
> Yes; maybe a comment like this would be better?
>   
>  # Also try an empty match suffix, to ensure that the `:=' in there is
>  # not confused by the parser with an unportable assignement operator.

Yes, thanks.

> > These 'test -x' commands fail on MinGW/MSYS because the file system does
> > not actually have execute permission information.
> >
> Ouch.
> 
> > Instead, it is emulated by looking at the file, and returning 0 if the
> > file starts with, e.g., a COFF header or with '#!'.
> > (The same heuristic is used when executing a script as well.)
> > 
> > You can thus fix this by either creating actual scripts in above rules
> > and the file creation below, or by removing the tests here.  I'm not
> > sure which you prefer.
> >
> I'd prefer the former, to keep the coverage a little bigger on non-MinGW
> systems.  Is that ok?

Yes, that's what I meant.

Thanks,
Ralf



reply via email to

[Prev in Thread] Current Thread [Next in Thread]