Re: [PATCH] tests: fix bug (comments-in-var-defn.test + autoconf 2.62)

[Stefano Lattarini]

On Friday 04 March 2011, Ralf Wildenhues wrote:
> Hi Stefano,
> 
> * Stefano Lattarini wrote on Fri, Mar 04, 2011 at 09:52:25AM CET:
> > * tests/comments-in-var-defn.test: The configure.in stub created
> > by default, which has the AC_INIT first argument obtained by the
> > test name, causes autoconf 2.62 to fail with a spurious error
> > message like: "configure.in:1: error: defn: undefined macro:".
> > Thus, to prevent this, the test is renamed to ...
> > * tests/comments-in-var-def.test: ... this.
> > * tests/Makefile.am (TESTS): Updated.
> 
> > OK to apply the attached patch to a temporary bugfixing branch based
> > off of  commit v1.11-263-g6318add (in which the offending test was
> > introduced), and merge into master?
> 
> Okay, though in general it would be preferable to avoid such bugs in
> tests/defs so we wouldn't have to remember them in the future.
> 
Or maybe we could define a "maintainer-check" that looks at the
testcases' names and complains about suspicious ones...  I'll
give it a shot unless someone beats me.

For the moment, I've pushed the patch as-is.

Thanks,
  Stefano