Re: [FYI] {maint,master} test defs: allow overriding of `$me'

[Ralf Wildenhues]

* Stefano Lattarini wrote on Mon, Apr 18, 2011 at 10:27:04AM CEST:
> On Monday 18 April 2011, Ralf Wildenhues wrote:
> > * Stefano Lattarini wrote on Sun, Apr 17, 2011 at 09:36:42PM CEST:
> > >  
> > > <http://lists.gnu.org/archive/html/automake-patches/2011-02/msg00044.html>
> > 
> > That explains why, from within the testsuite, you'd like to be able to
> > override it for some tests.  It doesn't explain why an override from the
> > user calling 'make check' should be possible.  (IOW, I understand the
> > "this would be convenient" aspect, but it seems it should be possible to
> > construct the testsuite in a way to still not allow user overrides.)
> >
> Honestly, I'd not worry about this ATM (but I share your concerns about
> the lack of namespace cleanliness).  Presently, a determined user can
> anyway wreak havoc by exporting variables such as 'required', 'MISSING'
> and 'parallel_tests' (and there are even more in the master branch:
> 'original_AUTOMAKE', 'am__using_gmake', 'instspc_action').

instspc_action is not dangerous, because its usage is safe, unlike
original_AUTOMAKE.  But 'me' is both a generic name, and dangerous
(me=../../../oops).  'required' is less dangerous that way, but still
a bit.

> A first
> step would IMHO be making these variables at least namespace-safe.
> Should I write a patch?

Oh no please don't; the others are at least not so generic names, and
I'd really loath the ripple that renaming $required will have.

I would like to put out a stable point release in the near future and
I'd prefer not so much churn before that.  (Yeah, it doesn't really mesh
well with me having close to no time at all right now, but it's about
time we did that ...)

Thanks,
Ralf