automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [FYI] {maint} tests: report useful system information from 'test-sui


From: Stefano Lattarini
Subject: Re: [FYI] {maint} tests: report useful system information from 'test-suite.log'
Date: Thu, 22 Dec 2011 18:18:35 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.24) Gecko/20111114 Icedove/3.1.16

On 12/22/2011 03:58 PM, Stefano Lattarini wrote:
> 
> On 12/22/2011 03:41 PM, Eric Blake wrote:
>>
>> On 12/22/2011 07:30 AM, Stefano Lattarini wrote:
>>>
>>> +# Dummy test case, aimed at reporting useful system information in the
>>> +# final `test-suite.log'.  This way, if a user experiencing a failure in
>>> +# the Automake test suite only sends us the `test-suite.log' file upon,
>>> +# we won't have to ask him for more information to start analyzing the
>>> +# failure (that had happened too many times in the past!).
>>
>> grammar:
>>
>> This way, if a user experiences a failure in the Automake test suite,
>> then only sends us the `test-suite.log', we won't have to...
>>
> Will fix in a follow-up (probably this evening).
>
Done with the attached patch.

>>> +
>>> +if test $st -eq 0; then
>>> +  # This test SKIPs, so that all the information is has gathered and
>>
>> s/is has //
>>
> Ditto.
> 
Here I preferred to do s/is has/it has/; hope it's OK as well (it seems
to me).

Thanks,
  Stefano

Attachment: 0001-fix-typos-and-grammaros-in-comments-of-the-new-test.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]