[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] depcomp: recognize tabs as whitespace in the dashmstdout mod
From: |
Stefano Lattarini |
Subject: |
Re: [PATCH] depcomp: recognize tabs as whitespace in the dashmstdout mode |
Date: |
Fri, 03 Feb 2012 09:35:55 +0100 |
Hi Peter.
On 02/03/2012 08:58 AM, Peter Rosin wrote:
> Commit Release-1-7-2b-2-gf03ceab "Cope with DOS filenames in
> dependencies." inadvertently converted tabs into spaces.
>
> * lib/depcomp (dashmstdout): Add a tab character to all sets
> matching whitespace.
> ---
> lib/depcomp | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
>
> I know the Tru64 patch to depcomp is out there, and will wait with
> pushing this one until that one has been processed, but I just wanted
> to get this out...
>
Don't worry about that patch, your objection to how the depcomp.tap
test is written makes a lot of sense (unfortunately for me), so I now
think the right fix for bug #10434 will be to change the test case
instead of the depcomp script.
> Ok for msvc?
>
Almost... to avoid similar regressions in the future, I think we
could introduce a new '$tab' variable and use that instead... and
then, for extra safety, we might even add a sanity check like:
case "$tab" in *\ *) fatal "\$tab is not a TAB";; esac
early in the script, to ensure $tab is not messed up by editors or
plain old carelessness.
WDYT?
Thanks,
Stefano
- [PATCH] depcomp: recognize tabs as whitespace in the dashmstdout mode, Peter Rosin, 2012/02/03
- Re: [PATCH] depcomp: recognize tabs as whitespace in the dashmstdout mode,
Stefano Lattarini <=
- Re: [PATCH] depcomp: recognize tabs as whitespace in the dashmstdout mode, Peter Rosin, 2012/02/03
- Re: [PATCH] depcomp: recognize tabs as whitespace in the dashmstdout mode, Stefano Lattarini, 2012/02/03
- Re: [PATCH] depcomp: recognize tabs as whitespace in the dashmstdout mode, Peter Rosin, 2012/02/03
- Re: [PATCH] depcomp: recognize tabs as whitespace in the dashmstdout mode, Stefano Lattarini, 2012/02/03
- Re: [PATCH] depcomp: recognize tabs as whitespace in the dashmstdout mode, Peter Rosin, 2012/02/03
- Re: [PATCH] depcomp: recognize tabs as whitespace in the dashmstdout mode, Stefano Lattarini, 2012/02/03
- Re: [PATCH] depcomp: recognize tabs as whitespace in the dashmstdout mode, Jim Meyering, 2012/02/03
- Re: [PATCH] depcomp: recognize tabs as whitespace in the dashmstdout mode, Peter Rosin, 2012/02/03
- Re: [PATCH] depcomp: recognize tabs as whitespace in the dashmstdout mode, Eric Blake, 2012/02/03
- Re: [PATCH] depcomp: recognize tabs as whitespace in the dashmstdout mode, Jim Meyering, 2012/02/03