Re: [FYI] {master} tests: workaround for shells with broken 'set -e'

[Stefano Lattarini]

On 02/06/2012 10:24 PM, Stefano Lattarini wrote:
> * tests/defs (gmake, native, rst2html): Some versions of the BSD
> shell wrongly bail out when the 'errexit' shell flag is active and
> the left-hand command in a "&&" list fails, if that list is the
> *last* command of a "for" or "while" loop.  Work around this issue.
> * tests/lex3.test: Likewise.
> * tests/check12.test: Likewise.
> * tests/lex-noyywrap.test: Likewise.
> * tests/parallel-tests2.test: Likewise.
> * tests/lex-lib-external.test: Likewise.
> * tests/check-no-test-driver.test: Likewise.
> * tests/test-metadata-recheck.test: Likewise.
> * tests/parallel-tests-dry-run-1.test: Likewise.
> * tests/parallel-tests-dry-run-2.test: Likewise.
> * tests/parallel-tests-unreadable.test: Likewise.
> * tests/test-driver-custom-no-extra-driver.test: Likewise.
> 
> Problem revealed by spurious testsuite failures on a NetBSD 5.1
> system and an OpenBSD 5.0 system.
> ---
>  tests/check-no-test-driver.test               |    1 +
>  tests/check12.test                            |    1 +
>  tests/defs                                    |   17 ++++++++++++++---
>  tests/lex-lib-external.test                   |    3 ++-
>  tests/lex-noyywrap.test                       |    5 +++--
>  tests/lex3.test                               |    5 +++--
>  tests/parallel-tests-dry-run-1.test           |    5 ++++-
>  tests/parallel-tests-dry-run-2.test           |    1 +
>  tests/parallel-tests-unreadable.test          |    3 ++-
>  tests/parallel-tests2.test                    |    5 ++++-
>  tests/test-driver-custom-no-extra-driver.test |    3 ++-
>  tests/test-metadata-recheck.test              |    1 +
>  12 files changed, 38 insertions(+), 12 deletions(-)
> 
And please consider this squashed in:

  diff --git a/tests/yacc-basic.test b/tests/yacc-basic.test
  index aef08c1..ee153f4 100755
  --- a/tests/yacc-basic.test
  +++ b/tests/yacc-basic.test
  @@ -62,6 +62,7 @@ test -f parse.c
   if cross_compiling; then :; else
     echo a | ./foo
     echo b | ./foo && Exit 1
  +  : For shells with busted 'set -e'.
   fi

   # The generated file `parse.c' must be shipped.

Sorry for the noise,
  Stefano