Re: [PATCH] {master} depcomp tests: avoid redundant runs for libtool tests

[Peter Rosin]

Stefano Lattarini skrev 2012-02-08 22:16:
> When running libtool-oriented tests, our 'depcomp.sh' script used
> to run the same checks thrice: once after having run configure
> with the '--disable-shared' option, once after having run it with
> the '--enable-shared' option, and once by allowing configure to
> automatically select which kind of library (or libraries) to build.
> 
> This was done to offer extra coverage for the less-common depmodes
> that run through slightly different code paths in the libtool and
> non-libtool cases (see for example commit 'Release-1-10-24-ge89ec38'
> of 28-03-2007, "* lib/depcomp (aix): Rewrite depmode in the spirit
> of the tru64 one").
> 
> But this coverage come at the price of slowing down considerably the
> depcomp libtool-oriented tests, since for each of them the tested
> source tree was configured and built *twelve* times (rather than
> "just" four as it is for the non-libtool case).
> 
> So, to strike a balance between coverage and speed, we now run the
> libtool-oriented tests with the three different configuration modes
> only for those
> 
> * tests/depcomp.sh: Adjust to only run the threefold libtool tests
> when the depmode is one of 'sgi', 'aix', 'hp2', 'tru64' or 'msvc7'.
> ---
>  tests/depcomp.sh |   42 +++++++++++++++++++++++++++++++++---------
>  1 files changed, 33 insertions(+), 9 deletions(-)
> 
> -*-*-*-
> 
> This is the first of the promised optimizations for the depcomp
> tests.  I will push in 48 hours if there is no objection.
> 
> Regards,
>   Stefano
> 
> -*-*-*-

*snip*

> +# Keep this in sync with the contents of 'lib/depcomp'.  We could
> +# probably extract this information automatically, but that looks
> +# like overkill ATM.
> +
> +case $depcomp_with_libtool,$depmode in
> +  yes,sgi|yes,aix|yes,hp2|yes,tru64|yes,msvc7)

I don't know if you consciously left out msvc7msys, but if you only
wanted one of the two I'd prefer msvc7msys over msvc7, since that's
the saner of the two (IMHO).

Cheers,
Peter