automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[FYI] {master} tests: avoid yet other spurious failures on NetBSD


From: Stefano Lattarini
Subject: [FYI] {master} tests: avoid yet other spurious failures on NetBSD
Date: Tue, 14 Feb 2012 00:16:35 +0100

* tests/tap-signal.tap: Add a "strategically placed" extra 'echo'
command and a temporary silencing of xtraces; they are required
to avoid possible garbled output with NetBSD make, which would
miss some final newlines in the expected places and thus mess up
our TAP output.
---
 tests/tap-signal.tap |   10 +++++++++-
 1 files changed, 9 insertions(+), 1 deletions(-)

diff --git a/tests/tap-signal.tap b/tests/tap-signal.tap
index f436bc8..e14cc50 100755
--- a/tests/tap-signal.tap
+++ b/tests/tap-signal.tap
@@ -98,7 +98,15 @@ signal_caught ()
   esac
 }
 
-command_ok_ '"make check" fails' eval 'not $MAKE check >stdout'
+command_ok_ '"make check" fails' eval '
+  (
+    st=0; $MAKE check >stdout || st=$?
+    # Extra "echo" and silencing of xtraces required to avoid possible
+    # garbled output with NetBSD make, which would miss some final
+    # newlines in the expected places and thus mess up our TAP output.
+    set +x; echo
+  )
+'
 cat stdout # For debugging.
 
 command_ok_ "count of test results" count_test_results \
-- 
1.7.7.3




reply via email to

[Prev in Thread] Current Thread [Next in Thread]