[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/5] Convert automake testsuite to the use of a POSIX shell
From: |
Eric Blake |
Subject: |
Re: [PATCH 0/5] Convert automake testsuite to the use of a POSIX shell |
Date: |
Tue, 01 May 2012 10:18:53 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120424 Thunderbird/12.0 |
On 05/01/2012 10:04 AM, Stefano Lattarini wrote:
> This patches are the first step in that direction. I will push in 72 hours
> if there is no objection.
Heads up - I'd like to review this series closely, but am not sure I
will finish my review in 72 hours.
Just so I know what to look for - is this just the use of the POSIX
shell in the automake testsuite, but that Makefile.in generated by
Automake still work with Solaris /bin/sh? Also, I'm assuming that you
are using hand-written shell scripts to get to this point, rather than
using autoconf's m4sh language to build up your testsuite scripts?
>
> Stefano Lattarini (5):
> tests: shell running test scripts is now named AM_TEST_RUNNER_SHELL
> configure: search a sturdy POSIX shell to be used in the testsuite
> tests: remove obsolete uses of $sh_errexit_works
> test defs: fix indentation (cosmetic change)
> tests: fix a spurious failure with dash
>
> Makefile.am | 4 +-
> NEWS | 11 +++
> configure.ac | 185
> +++++++++++++++++++++++++++++++++++++---
> defs | 124 +++++++++++++--------------
> defs-static.in | 11 ++-
> t/self-check-cleanup.tap | 21 +++--
> t/self-check-dir.tap | 9 +-
> t/self-check-env-sanitize.tap | 4 +-
> t/self-check-exit.tap | 35 +++-----
> t/self-check-explicit-skips.sh | 17 ++--
> t/self-check-me.tap | 8 +-
> t/self-check-reexec.tap | 18 ++--
> t/self-check-sanity.sh | 8 +-
> t/self-check-tap.sh | 16 ++--
> 14 files changed, 320 insertions(+), 151 deletions(-)
>
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [PATCH 1/5] tests: shell running test scripts is now named AM_TEST_RUNNER_SHELL, (continued)