automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[FYI] [ng] maintcheck: remove a test that can't work for Automake-NG


From: Stefano Lattarini
Subject: [FYI] [ng] maintcheck: remove a test that can't work for Automake-NG
Date: Wed, 20 Jun 2012 16:40:45 +0200

* syntax-checks.mk (sc_tests_makefile_variable_order): Remove.  This
rule checked that all variables definitions were listed before rules
in the automake-generated Makefile.in files; but this invariant is not
guaranteed anymore by Automake-NG, and in fact it will break more and
more as our work proceeds.
(syntax_check_rules): Update.

Signed-off-by: Stefano Lattarini <address@hidden>
---
 syntax-checks.mk |   23 -----------------------
 1 file changed, 23 deletions(-)

diff --git a/syntax-checks.mk b/syntax-checks.mk
index e55a94a..27b91a9 100644
--- a/syntax-checks.mk
+++ b/syntax-checks.mk
@@ -77,7 +77,6 @@ sc_tests_plain_sleep \
 sc_m4_am_plain_egrep_fgrep \
 sc_tests_PATH_SEPARATOR \
 sc_tests_logs_duplicate_prefixes \
-sc_tests_makefile_variable_order \
 sc_perl_at_substs \
 sc_unquoted_DESTDIR \
 sc_tabs_in_texi \
@@ -523,28 +522,6 @@ sc_tests_logs_duplicate_prefixes: 
sc_ensure_testsuite_has_run
          exit 1; \
        fi
 
-## Ensure variables are listed before rules in Makefile.in files we generate.
-sc_tests_makefile_variable_order: sc_ensure_testsuite_has_run
-       @st=0; \
-       for file in `find t -name Makefile.in -print`; do \
-         latevars=`sed -n \
-           -e :x -e 's/#.*//' \
-           -e '/\\\\$$/{' -e N -e 'b x' -e '}' \
-           -e '# Literal TAB.' \
-           -e '1,/^    /d' \
-           -e '# Allow @ so we match conditionals.' \
-           -e '/^ address@hidden,\} *=/p' $$file`; \
-         if test -n "$$latevars"; then \
-           echo "Variables are expanded too late in $$file:" >&2; \
-           echo "$$latevars" | sed 's/^/  /' >&2; \
-           st=1; \
-         fi; \
-       done; \
-       test $$st -eq 0 || { \
-         echo 'Ensure variables are expanded before rules' >&2; \
-         exit 1; \
-       }
-
 ## Using ':' as a PATH separator is not portable.
 sc_tests_PATH_SEPARATOR:
        @if grep -E '\bPATH=.*:.*' $(xtests) ; then \
-- 
1.7.9.5




reply via email to

[Prev in Thread] Current Thread [Next in Thread]