Re: [PATCH 0/3] ylwrap: handle header inclusion properly

[Stefano Lattarini]

Hi Akim.

On 07/12/2012 03:51 PM, Akim Demaille wrote:
> The following patches address a bug in ylwrap that cause it
> to be unable to handle Bison glr parsers, but also prevents
> future Bison releases from also using header inclusion in yacc mode.
>
Thanks!  A review of your patches will follow shortly.

Apart from that, on which systems can you test your series?  I think
it should be tested at least on Solaris and a BSD system in addition
to GNU/Linux.

> A related, but different, matter consists in using the -o
> option when supported by yacc.
>
I'm not going to work on that anytime soon (and anyway, I'm waiting
to hear back from the Autoconf guys after this message):
<http://lists.gnu.org/archive/html/autoconf/2012-06/msg00051.html>
So feel free to give it a shot if you want to ;-)

> BTW, there are plenty of files that should be git ignored.
> Should I add them?
> 
>  ~/src/gnu/automake $ git st
> # On branch master
> # Your branch is ahead of 'origin/master' by 3 commits.
> #
> # Untracked files:
> #   (use "git add <file>..." to include in what will be committed)
> #
> #       autom4te.cache/
>
In automake, we've renamed our autom4te cache to .autom4te.cache:

  $ cat .autom4te.cfg
  ## autom4te.cfg for the Automake package.
  ##
  begin-language: "Autoconf-without-aclocal-m4"
  args: --cache=.autom4te.cache
  end-language: "Autoconf-without-aclocal-m4"

So your 'autom4te.cache/' is a left-over from older versions; just
remove it.

> #       contrib/Makefile.in
> #       doc/Makefile.in
> #       lib/Automake/Makefile.in
> #       lib/Makefile.in
> #       lib/am/Makefile.in
> #       m4/Makefile.in
>
Likewise, leftovers from older versions: we now use a non-recursive
build system in Automake, so the only Makefile.in is the one in the
top directory.  Just remove all the others 'Makefile.in' files.

> 
> Akim Demaille (3):
>   ylwrap: refactor
>   ylwrap: simplify the list of renamings
>   ylwrap: rename header inclusion in generated parsers
> 
>  lib/am/yacc.am    |   3 +-
>  lib/ylwrap        | 118 
> ++++++++++++++++++++++++++++++------------------------
>  t/yacc-d-basic.sh |   9 ++++-
>  3 files changed, 74 insertions(+), 56 deletions(-)
> 

Regards,
  Stefano