Re: [PATCH 2/3] ylwrap: simplify the list of renamings

[Akim Demaille]

Le 12 juil. 2012 à 17:51, Stefano Lattarini a écrit :

> On 07/12/2012 03:51 PM, Akim Demaille wrote:
>> * lib/ylwrap (pairwise): Instead of being a straightforward copy from
>> the command line arguments, and having to deal with y.tab vs. y_tab
>> later, let pairwise store the real file names to process, y_tab
>> conversion included when needed.
>> (main loop): Use $to instead of $2, for symmetry with $from.
>> ---
>> 
> ACK, but for ...
> 
>> @@ -215,9 +218,9 @@ if test $ret -eq 0; then
>>         ret=1
>>       fi
>>     fi
>> +    first=no
>>     shift
>>     shift
>> -    first=no
>>   done
>> else
>>   ret=$?
>> 
> ... this useless change, that IMHO should be removed.

Sure.

> Also, taking a step back, we might ask: do we actually need continuing to
> support DOS?  We see that doing so might (as in this case) add an extra
> burden on the developers, for no real advantage IMHO (DJGPP user base today
> is ... what, 20 people?), and without any chance for the changes to be
> properly tested anyway (who is testing or using Automake on DJGPP)?
> 
> Just thinking aloud here; do not consider this as a blocker of your patch
> (which is still ACK'd), just a suggestion to myself as well as to others
> for possible further changes.

I have absolutely no opinion here.  That's something that's part of
Automake specifications.