[PATCH 00/32] {maint} Several testsuite refactorings

[Stefano Lattarini]

Some of these are mere cleanup, cosmetic factorization or minor usability
improvements.  Others constitute the first step in the quest to merge the
generically useful parts of our test suite framework in a more generic
project, like Gnulib.  Time will tell if we'll succeed, and whether the
success will be worth the extra hassle (I sincerely believe and hope so).

I plan to push the series by this evening.

Regards,
  Stefano

-*-*-*-

Stefano Lattarini (32):
  cosmetics: remove leftover comment fragment from runtest.in
  runtest: correctly pass shell option also for TAP tests
  runtest: pass *all* the given shell options to the test invocation
  perf tests: reorganize
  build: auxiliary testsuite files/scripts built by "make all"
  gen-tests: less hard-coding of 't' as the test directory
  gen-tests: $testdir/ax -> $testauxdir
  runtest: export $srcdir for use by the test scripts
  tests: update PATH early from AM_TESTS_ENVIRONMENT and runtest
  test defs: move in 't/ax/test-defs.sh'
  tests: simplify sourcing of helper shell files
  test init: remove a couple of paranoid sanity checks
  test init: refactor: new function 'require_tool'
  test init: refactor: new function 'process_requirements'
  test init: refactor: new function 'am_exit_trap'
  configure: testsuite shell set exit traps in shell functions
  test init: refactor: new function 'am_set_exit_traps'
  test init: refactor: new function 'am_setup_testdir'
  test init: refactor: move displaying of debugging info later
  test init: refactor: new function 'am_test_setup'
  test setup: merge definitions of function for simple tests
  test setup: move actual calling of testsuite setup in ./defs
  tests: split test libs into "generic" and "automake-specific"
  test defs: no need to re-add $srcdir/t/ax to $PATH
  tests: source test defs in the generic test lib
  tests: move sanitization and "Bournification" in the generic test lib
  configure: testsuite shell can return early from "dot-sourced" files
  tests: protect test libs against multiple inclusion
  tests: "am_using_tap=yes" -> "am_test_protocol=tap"
  tests: remove an obsolescent self test
  runtest: sanitize test environment
  tests: never source test-defs.sh directly, source test-lib.sh instead

 .gitignore                                 |   2 +-
 Makefile.am                                |  58 ++++--
 configure.ac                               |  13 ++
 defs                                       |  12 +-
 gen-testsuite-part                         |  35 ++--
 runtest.in                                 |  55 ++++-
 syntax-checks.mk                           |   6 +-
 t/README                                   |   2 +-
 t/ax/{test-init.sh => am-test-lib.sh}      | 312 ++++-------------------------
 t/ax/plain-functions.sh                    |  40 ----
 t/ax/tap-setup.sh                          |   2 +-
 defs-static.in => t/ax/test-defs.in        |  74 +------
 t/ax/test-lib.sh                           | 296 +++++++++++++++++++++++++++
 t/list-of-tests.mk                         |   3 -
 t/self-check-env-sanitize.tap              |  56 ------
 t/self-check-tap.sh                        |  45 -----
 t/tap-ambiguous-directive.sh               |   2 +-
 t/tap-autonumber.sh                        |   2 +-
 t/tap-bailout-and-logging.sh               |   2 +-
 t/tap-bailout-leading-space.sh             |   2 +-
 t/tap-bailout-suppress-badexit.sh          |   2 +-
 t/tap-bailout-suppress-later-diagnostic.sh |   2 +-
 t/tap-bailout-suppress-later-errors.sh     |   2 +-
 t/tap-bailout.sh                           |   2 +-
 t/tap-color.sh                             |   2 +-
 t/tap-deps.sh                              |   2 +-
 t/tap-diagnostic.sh                        |   2 +-
 t/tap-empty-diagnostic.sh                  |   2 +-
 t/tap-empty.sh                             |   2 +-
 t/tap-escape-directive-2.sh                |   2 +-
 t/tap-escape-directive.sh                  |   2 +-
 t/tap-exit.sh                              |   2 +-
 t/tap-fancy.sh                             |   2 +-
 t/tap-fancy2.sh                            |   2 +-
 t/tap-global-log.sh                        |   2 +-
 t/tap-global-result.sh                     |   2 +-
 t/tap-log.sh                               |   2 +-
 t/tap-merge-stdout-stderr.sh               |   2 +-
 t/tap-missing-plan-and-bad-exit.sh         |   2 +-
 t/tap-msg0-bailout.sh                      |   2 +-
 t/tap-msg0-directive.sh                    |   2 +-
 t/tap-msg0-misc.sh                         |   2 +-
 t/tap-msg0-planskip.sh                     |   2 +-
 t/tap-msg0-result.sh                       |   2 +-
 t/tap-negative-numbers.sh                  |   2 +-
 t/tap-no-disable-hard-error.sh             |   2 +-
 t/tap-no-merge-stdout-stderr.sh            |   2 +-
 t/tap-no-spurious-numbers.sh               |   2 +-
 t/tap-no-spurious-summary.sh               |   2 +-
 t/tap-no-spurious.sh                       |   2 +-
 t/tap-not-ok-skip.sh                       |   2 +-
 t/tap-number-wordboundary.sh               |   2 +-
 t/tap-numbers-leading-zero.sh              |   2 +-
 t/tap-numeric-description.sh               |   2 +-
 t/tap-out-of-order.sh                      |   2 +-
 t/tap-passthrough-exit.sh                  |   2 +-
 t/tap-passthrough.sh                       |   2 +-
 t/tap-plan-corner.sh                       |   2 +-
 t/tap-plan-errors.sh                       |   2 +-
 t/tap-plan-leading-zero.sh                 |   2 +-
 t/tap-plan-malformed.sh                    |   2 +-
 t/tap-plan-middle.sh                       |   2 +-
 t/tap-plan-whitespace.sh                   |   2 +-
 t/tap-plan.sh                              |   2 +-
 t/tap-planskip-and-logging.sh              |   2 +-
 t/tap-planskip-badexit.sh                  |   2 +-
 t/tap-planskip-bailout.sh                  |   2 +-
 t/tap-planskip-case-insensitive.sh         |   2 +-
 t/tap-planskip-late.sh                     |   2 +-
 t/tap-planskip-later-errors.sh             |   2 +-
 t/tap-planskip-unplanned-corner.sh         |   2 +-
 t/tap-planskip-unplanned.sh                |   2 +-
 t/tap-planskip-whitespace.sh               |   2 +-
 t/tap-planskip.sh                          |   2 +-
 t/tap-realtime.sh                          |   2 +-
 t/tap-recheck-logs.sh                      |   2 +-
 t/tap-result-comment.sh                    |   2 +-
 t/tap-summary-color.sh                     |   4 +-
 t/tap-summary.sh                           |   4 +-
 t/tap-test-number-0.sh                     |   2 +-
 t/tap-todo-skip-together.sh                |   2 +-
 t/tap-todo-skip-whitespace.sh              |   2 +-
 t/tap-todo-skip.sh                         |   2 +-
 t/tap-unplanned.sh                         |   2 +-
 t/tap-whitespace-normalization.sh          |   2 +-
 t/tap-with-and-without-number.sh           |   2 +-
 t/tap-xfail-tests.sh                       |   2 +-
 t/testsuite-summary-color.sh               |   8 +-
 t/testsuite-summary-count.sh               |   8 +-
 89 files changed, 562 insertions(+), 611 deletions(-)
 rename t/ax/{test-init.sh => am-test-lib.sh} (75%)
 delete mode 100644 t/ax/plain-functions.sh
 rename defs-static.in => t/ax/test-defs.in (74%)
 create mode 100644 t/ax/test-lib.sh
 delete mode 100755 t/self-check-env-sanitize.tap
 delete mode 100755 t/self-check-tap.sh

-- 
1.7.12.rc0