[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: bug#13524: Improving user experience for non-recursive builds
From: |
Peter Rosin |
Subject: |
Re: bug#13524: Improving user experience for non-recursive builds |
Date: |
Mon, 04 Feb 2013 10:35:48 +0100 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
On 2013-02-04 00:10, Peter Rosin wrote:
> On 2013-02-03 21:42, Stefano Lattarini wrote:
>> I've pushed the promised patches to the rewindable branch
>> 'experimental/preproc' (based off of maint). I'll also soon
>> send them to the list to simplify review (I will drop the
>> bug tracker from CC:, to avoid cluttering up the report).
>>
>> As usual, reviews are welcome.
>
> I like the end result of this series, I especially like that I don't have
> to type &{this}& anymore.
*snip*
Oops, a couple more things. The new naming will clobber
anyone using a Makefile variable named RELDIR with brace
syntax. E.g., this previously working code is broken by
the series.
RELDIR = src
foobar_CPPFLAGS = $(AM_CPPFLAGS) -DRELDIR=${RELDIR}
It will be preprocessed into
RELDIR = src
foobar_CPPFLAGS = $(AM_CPPFLAGS) -DRELDIR=$src
and quasi-expanded into (assuming $s is empty)
foobar_CPPFLAGS = $(AM_CPPFLAGS) -DRELDIR=rc
Not sure what to do about it, or if it matters...
Further, the use of /dev/full in the demo test is not
portable. If I create /dev on Windows (i.e. C:\dev, or have
it previously, I didn't, but not unlikely), and am allowed
to write there (likely, on Windows), and /dev/full isn't
supported (where is it supported, except Linux?), then the
test falls apart. The MinGW program happily writes "dummy"
to /dev/full (i.e. C:\dev\full from its view of the file
system) but the MSYS script does not think /dev/full is a
character device and it is not be allowed to write to
/dev/full either, because typically /dev doesn't exist as
a real directory. Typically /dev is virtual in MSYS (if it
existed, it would be C:\MinGW\msys\1.0\dev from the MSYS
view of the file system) so it assumes the MinGW program
skipped, but it didn't.
Why use special features like /dev/full in the testsuite of
Automake? Surely there are better things one can do to check if
a Makefile works. Mixing in stuff like that is just a recipe
for strange bug reports and hardship for those on weird
platforms. The gain for Automake is zero.
Also, creating the file /dev/full with content "dummy" is
bad manors, even if someone runs the testsuite as root (on a
system not supporting /dev/full) and arguably deserves it.
Cheers,
Peter
- Re: bug#13524: Improving user experience for non-recursive builds, Stefano Lattarini, 2013/02/03
- [PATCH 0/6] Add support for relative names in included fragments, Stefano Lattarini, 2013/02/03
- [PATCH 1/6] preproc: add support for relative names in included fragments, Stefano Lattarini, 2013/02/03
- [PATCH 2/6] preproc: enhance and extend tests, Stefano Lattarini, 2013/02/03
- [PATCH 4/6] preproc: better (long) name for built-in '{...}' substitutions, Stefano Lattarini, 2013/02/03
- [PATCH 5/6] NEWS: improve wording about new {RELDIR} preproc support, Stefano Lattarini, 2013/02/03
- [PATCH 6/6] automake: fixups for read_am_file() and calling code, Stefano Lattarini, 2013/02/03
- [PATCH 3/6] preproc: prefer '{D}' over '&{D}&' (and similarly for other substs), Stefano Lattarini, 2013/02/03
- Re: bug#13524: Improving user experience for non-recursive builds, Peter Rosin, 2013/02/03
- Re: bug#13524: Improving user experience for non-recursive builds,
Peter Rosin <=
- Re: bug#13524: Improving user experience for non-recursive builds, Stefano Lattarini, 2013/02/04
- Re: bug#13524: Improving user experience for non-recursive builds, Peter Rosin, 2013/02/04
- Re: bug#13524: Improving user experience for non-recursive builds, Stefano Lattarini, 2013/02/04
- Re: bug#13524: Improving user experience for non-recursive builds, Peter Rosin, 2013/02/04
- Re: bug#13524: Improving user experience for non-recursive builds, Stefano Lattarini, 2013/02/04
- Re: bug#13524: Improving user experience for non-recursive builds, Eric Blake, 2013/02/04
- Re: bug#13524: Improving user experience for non-recursive builds, Stefano Lattarini, 2013/02/04
- Re: bug#13524: Improving user experience for non-recursive builds, Peter Rosin, 2013/02/04
- Re: bug#13524: Improving user experience for non-recursive builds, Miles Bader, 2013/02/04
- Re: bug#13524: Improving user experience for non-recursive builds, Stefano Lattarini, 2013/02/07