Re: [PATCH] t/pm: Use Test::Simple for Perl tests

[Mathieu Lirzin]

Hello Matthias,

Matthias Paulmier <address@hidden> writes:

> This patch enables the use of the Test::Simple (and Test::More) library
> for the Perl lib tests.  One point that may need reflexion is wether or
> not to keep the "old" way of testing Perl libraries into Automake (that
> is without using Test::Simple/More).
>
> This patch is part of my GSoC project.  I am sorry it took so long and
> will make sure to submit the rest of my modifications in the comming days.

This is already a big chunk to review so please wait for this patch to
be reviewed and applied before sending the other ones.  ;-)

> From b0a682a918242b3a74147cd60aadf4e543eb5ce0 Mon Sep 17 00:00:00 2001
> From: Matthias Paulmier <address@hidden>
> Date: Thu, 30 Aug 2018 16:30:19 +0200
> Subject: [PATCH] t/pm: Use Test::Simple for the tests of the Perl libraries
>
> This allows to have more tests using the TAP protocol for tests.  We can also
> use other libraries such as Test::More.  For these tests, we use a new
> extension (.plt) for those tests.  This change does not exclude the "old" way
> of doing things as the .pl extension still exists in t/local.mk in case
> someone wants to test the old way.
>
> * t/pm: Use eval to fix fail XFAIL perl test and catch fatal errors.
> * t/pm: Regroup tests by module (consequence of the above).
> * t/pm: Add a new extension for Perl tests using Test::Simple (.plt).
> * t/pm: Move all current tests to the .plt extension.
> * lib/Automake: Move END to its own submodule to fix a termination bug with
>   Test::Simple where STDOUT was closed and then reopened.
> ---
>  bin/aclocal.in                                |   1 +
>  bin/automake.in                               |   1 +
>  lib/Automake/End.pm                           |  47 +++++++
>  lib/Automake/General.pm                       |  24 +---
>  lib/Automake/local.mk                         |   1 +
>  t/list-of-tests.mk                            |  33 ++---
>  t/local.mk                                    |   4 +-
>  t/pm/Cond2.pl                                 |  22 ----
>  t/pm/Cond3.pl                                 |  22 ----
>  t/pm/{Condition-t.pl => Condition-t.plt}      |  12 +-
>  t/pm/{Condition.pl => Condition.plt}          |  34 ++++-
>  t/pm/DisjCon2.pl                              |  24 ----
>  t/pm/DisjCon3.pl                              |  23 ----
>  ...sjConditions-t.pl => DisjConditions-t.plt} |  12 +-
>  .../{DisjConditions.pl => DisjConditions.plt} |  36 +++++-
>  t/pm/{General.pl => General.plt}              |  10 +-
>  t/pm/Version.pl                               | 112 ----------------
>  t/pm/Version.plt                              | 122 ++++++++++++++++++
>  t/pm/Version2.pl                              |  20 ---
>  t/pm/Version3.pl                              |  20 ---
>  t/pm/{Wrap.pl => Wrap.plt}                    |  23 ++--
>  21 files changed, 277 insertions(+), 326 deletions(-)

This patch is too fat for me to properly review it.  The changelog
description makes me think it could easily be separated in smaller
chunks.  For example you could make one patch adding support for
‘Test::Simple’ and a basic test file with a ‘.plt’ extension, one patch
for each test file migrated to Test::Simple, one for fixing the XFAIL
hack...

Feel free to adapt to your particular case, since you understand the
dependencies between the change you made better than I do.

Can you send the updated patches?

Thanks.

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37