Re: PATCH: patsubst support

[Akim Demaille]

| Akim,

Hi Alex,

Glad to see your progresses!

| Here is a patch to add patsubst support to value_to_list. I've
| included a new test case "patsubst.test" as well. 

That's great news!  Thanks a lot!

But I'm going to be a pain, especially because I'm not the official
maintainer of Automake, and understand it much less than I understand
Autoconf, so I will be even more picky than I already am for Autoconf
patches (wow!  That much!?! :).

| diff -r -P -u automake/ChangeLog.entry automake-patsubst/ChangeLog.entry
| --- automake/ChangeLog.entry  Thu Jan  1 01:00:00 1970
| +++ automake-patsubst/ChangeLog.entry Wed Oct 25 14:16:08 2000
| @@ -0,0 +1,5 @@
| +2000-10-25  Alex Hornby <address@hidden>
| +
| +     * automake.in (value_to_list): added support for patsubst
| +     style variable substitution.

Please use the imperative: you dictate the specification to someone
who will have to implement them.

| +     * automake.in (value_to_list): Adde support for patsubst
| +     style variable substitution.

| diff -r -P -u automake/automake.in automake-patsubst/automake.in
| --- automake/automake.in      Wed Oct 25 11:25:01 2000
| +++ automake-patsubst/automake.in     Wed Oct 25 14:20:07 2000
| @@ -5902,16 +5902,34 @@
|             {
|                 $varname = $1;
|                 $to = $3;
| -             ($from = $2) =~ s/(\W)/\\$1/g;
| +             ($from = $2) =~ s/(\W)/$1/g;
|             }
|  
|             # Find the value.
|             @temp_list = &variable_value_as_list_worker ($1, $cond, $var);
|  
|             # Now rewrite the value if appropriate.
| -         if ($from)
| +         if ($from =~ '^([^%]*)%([^%]*)')
|             {

I think some comments here would really help next hackers.  Let only
to state that here is handled the patsubst stuff.

| +2000-10-25  Alex Hornby <address@hidden>
| +
| +     * patsubst.test: added test for new patsubst expansion
| +
| +     * Makefile.am: reference patsubst.test

Likewise (plus capitalization and final period).

There are two important missing things in your patch: an entry for
NEWS, and the patch for the documentation.  I'm sorry to insist, but
yet the Automake documentation is slightly deficient, and hard work is
needed on that point.

        Akim