automake
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] m4/header.m4 bug


From: Derek R. Price
Subject: [PATCH] m4/header.m4 bug
Date: Fri, 15 Dec 2000 15:22:36 -0500

There was a bug in m4/header.m4 (AM_CONFIG_HEADER) which was causing
configure & config.status to create a $(top_builddir)/stamp-h file for
every header file instead of the $(top_builddir)/$(subdir)/stamp-h$index
file it was supposed to create.  Basically, a few shell metachars which
were supposed to be interpreted in config.status were being interpreted
in configure instead and leaving blank spots in config.status.  The
stamp files were still being created in the correct places in the
Makefile.ins & Makefiles, so it wasn't a fatal bug, but I fixed it
anyway.

Derek

--
Derek Price                      CVS Solutions Architect ( http://CVSHome.org )
mailto:address@hidden     OpenAvenue ( http://OpenAvenue.com )
--
Southern DOS: Y'all reckon? (yep/Nope)


Index: ChangeLog
===================================================================
RCS file: /cvs/automake/automake/ChangeLog,v
retrieving revision 1.910
diff -u -r1.910 ChangeLog
--- ChangeLog   2000/11/26 22:11:20     1.910
+++ ChangeLog   2000/12/15 19:55:12
@@ -1,3 +1,8 @@
+2000-12-15  Derek Price  <address@hidden>
+
+       * m4/header.m4 (AM_CONFIG_HEADER): This macro was broken due to
+       unescaped shell metachars
+
 2000-12-05  Derek Price  <address@hidden>
 
        * automake.in (require_file_with_conf_line,
Index: m4/header.m4
===================================================================
RCS file: /cvs/automake/automake/m4/header.m4,v
retrieving revision 1.7
diff -u -r1.7 m4/header.m4
--- m4/header.m4        2000/08/06 12:36:53     1.7
+++ m4/header.m4        2000/12/15 19:49:31
@@ -18,9 +18,9 @@
           patsubst([$1], [^\([^:]*/\)?.*], [\1])stamp-h]),
   [am_indx=1
   for am_file in $1; do
-    case " $CONFIG_HEADERS " in
-    *" $am_file "*)
-      echo timestamp > `echo $am_file | sed 
's%:.*%%;s%[^/]*$%%'`stamp-h$am_indx
+    case " \$CONFIG_HEADERS " in
+    *" \$am_file "*)
+      echo timestamp > \`echo \$am_file | sed 
's%:.*%%;s%[^/]*\$%%'\`stamp-h\$am_indx
       ;;
     esac
     am_indx=\`expr \$am_indx + 1\`

reply via email to

[Prev in Thread] Current Thread [Next in Thread]