[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: DIST_COMMON broke
From: |
Derek R. Price |
Subject: |
Re: DIST_COMMON broke |
Date: |
Wed, 07 Feb 2001 14:55:46 -0500 |
Pavel Roskin wrote:
> Hello, Derek!
>
> > > > Looks like someone broke the 'make dist' target in the last few days.
>
> I also noticed that.
>
> > > > Specifically, input files from AC_OUTPUT are no longer being added to
> > > > DIST_COMMON...
>
> Exactly the same problem.
>
> > > Here's the patch.
> >
> > This doesn't appear to be the correct fix. I'll write the test case
> > Tom just requested and see if I can't figure out anymore.
>
> How about this test (distdir2.test):
I've attached a slightly more succinct test for the original problem I pointed
out (distcommon.test). It's nice as a perquisite at least, as it doesn't
require autoconf or make... I'm not quite sure I understand the second
problem you pointed out.
It turns out that the first fix I sent in actually works, but I think it is
not the correct fix. It looks to me like require_file_with_conf_line is
supposed to be calling maybe_push_required_file for these files but isn't for
some reason.
Derek
--
Derek Price CVS Solutions Architect ( http://CVSHome.org )
mailto:address@hidden OpenAvenue ( http://OpenAvenue.com )
--
I saw nothing unusual in the teacher's lounge.
I saw nothing unusual in the teacher's lounge.
I saw nothing unusual in the teacher's lounge...
- Bart Simpson on chalkboard, _The Simpsons_
#! /bin/sh
# A test for failure to include files provided in AC_OUTPUT into DIST_COMMON
. $srcdir/defs || exit 1
cat > configure.in << EOF
AM_INIT_AUTOMAKE(nonesuch, nonesuch)
AC_OUTPUT(subdir/bar \
Makefile \
subdir/Makefile)
EOF
: > Makefile.am
mkdir subdir
: > subdir/Makefile.am
: > subdir/bar.in
$AUTOMAKE || exit 1
# verify bar.in
grep 'DIST_COMMON.*bar.in' subdir/Makefile.in || exit 1
exit 0
- Re: DIST_COMMON broke, Derek R. Price, 2001/02/07
- Re: DIST_COMMON broke, Derek R. Price, 2001/02/07
- Re: DIST_COMMON broke, Pavel Roskin, 2001/02/07
- Re: DIST_COMMON broke,
Derek R. Price <=
- Re: DIST_COMMON broke, Tom Tromey, 2001/02/07
- Re: DIST_COMMON broke, Pavel Roskin, 2001/02/07
- Re: DIST_COMMON broke, Tom Tromey, 2001/02/07
- Re: DIST_COMMON broke, Pavel Roskin, 2001/02/07
- Re: DIST_COMMON broke, Tom Tromey, 2001/02/07
- Re: DIST_COMMON broke, Derek R. Price, 2001/02/07
- Re: DIST_COMMON broke, Tom Tromey, 2001/02/07
- Re: DIST_COMMON broke, Derek R. Price, 2001/02/07
- Re: DIST_COMMON broke, Tom Tromey, 2001/02/07
- Re: DIST_COMMON broke, Derek R. Price, 2001/02/07