Re: Patch 1 of 4: Better DOS path support

[Akim Demaille]

"Tim Van Holder" <address@hidden> writes:

> - /* | [A-Za-z]:*) ;;
> - */*) prog="`pwd`/$prog" ;;
> + [/\\]* | [A-Za-z]:[/\\]*) ;;
> + *[\\/]*) prog="`pwd`/$prog" ;;

> @@ -11,7 +11,7 @@
>  # Always use an absolute srcdir.  Otherwise symlinks made in subdirs
>  # of the test dir just won't work.
>  case "$srcdir" in
> - /*)
> + [\\/]* | ?:[\\/]*)
>      ;;
> 
>   *)

My opinion is that there should be exactly one case pattern used
everywhere.  I can see they were different before your patch, but I'd
suggest that your patch makes them uniform.  And of course, the same
as promoted by autoconf.texi :)


> -    ln -s ../"$input" . > /dev/null 2>&1 || ln ../"$input" . > /dev/null
> 2>&1 || cp ../"$input" .

Please, don't cut and paste, your patches are not applicable.

> +    if test -n "$COMSPEC$ComSpec"; then
> +      # DOSish system: don't try ln -s; it is most likely broken.
> +      ln ../"$input" . > /dev/null 2>&1 || cp ../"$input" .
> +    else
> +      ln -s ../"$input" . > /dev/null 2>&1 || ln ../"$input" . > /dev/null
> 2>&1 || cp ../"$input" .
> +    fi
>      ;;

Hm, what was wrong?  I mean, ln -s was exit 0, but actually failed?