Re: 45-fix-yacc2-test.patch

[Tom Tromey]

>>>>> "Akim" == Akim Demaille <address@hidden> writes:

Akim> There is still one test which fails, but it's because I don't
Akim> know what happens: subobj2.test.

Consider this code in depend2.am:

    address@hidden@%FPFX%DEPMODE = @%FPFX%DEPMODE@

We include depend2.am once per extension.  But some languages, like
C++, have multiple extensions.  In this case, "FPFX" is always CXX.
So CXXDEPMODE is defined more than once.

In subobj2.test we are using both a `.cc' and a `.cxx' file in the
same program.  That is what triggers this.

Certainly this redefinition is a bit ugly.  I've never considered it a
fatal flaw.  However given that you're already making many changes in
this area you might as well fix this one somehow.

Akim> I am not sure it is right or wrong to use the C++ variables to
Akim> compile C code, so I am leaving the complaints from automake.

It isn't ok.  But I don't think that is what is happening in this
situation.

Akim>   * tests/yacc2.test: Don't define several times a variable, as
Akim>   automake complains.

Ok, provided you rename the temporary file as others have asked.

Tom