Re: Help: Automake's Struct.pm

[Akim Demaille]

>>>>> "Russ" == Russ Allbery <address@hidden> writes:

Russ> You seem to have based this on an older version of Class::Struct
Russ> than what shipped with Perl 5.6.1, 

I was not aware 5.6.1 was released...

Russ> unless you intended to delete the import stuff, and beyond that
Russ> the only change I see is a change from warnings::warn to
Russ> warnings::warnif.  

Hm, that's weird...  Here is what I meant to send (maybe I took the
wrong floppy...)

 perl5/5.005/Class % diff -uw /floppy/Struct.pm Struct2.pm
 --- /floppy/Struct.pm   Sat Mar 24 17:50:56 2001
 +++ Struct2.pm  Sun Mar 25 16:30:39 2001
 @@ -1,12 +1,11 @@
 -package Class::Struct;
 +package Class::Struct2;

  ## See POD after __END__

 -use 5.005_64;
 +use 5.005;

  use strict;
 -use warnings::register;
 -our(@ISA, @EXPORT, $VERSION);
 +use vars qw(@ISA @EXPORT $VERSION);

  use Carp;

 @@ -168,8 +167,7 @@
      $cnt = 0;
      foreach $name (@methods){
          if ( do { no strict 'refs'; defined &{$class . "::$name"} } ) {
 -            warnings::warn "function '$name' already defined, overrides struct
 accessor method"
 -                if warnings::enabled();
 +            carp "function '$name' already defined, overrides struct accessor 
method";
          }
          else {
              $pre = $pst = $cmt = $sel = '';


Russ> The AMStruct.pm file that you included won't work with any
Russ> released version of Perl older than 5.6.0; was that the
Russ> intention?

:) :) Definitely not.  What do you mean?