automake
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Warning fix for automake on CVS Libtool


From: Pavel Roskin
Subject: Re: Warning fix for automake on CVS Libtool
Date: Wed, 25 Apr 2001 10:08:48 -0400 (EDT)

Hello!

> This patch eliminates pushing undefined values to an array of suffixes to
> be cleaned for texinfo files.

It seems that my patch is not quite correct. It eliminates a warning that
possibly indicates a logic error. It's better to fix the problem than to
hide it.

> -        push @clean_suffixes, $hidden_index{$1};
> +        push @clean_suffixes, $hidden_index{$1}
> +       if (defined $hidden_index{$1});

I doubt that we should just go ahead without taking any action if for
@defxxx we cannot find xxx in %hidden_index.

I'll be busy today, but I promise to look into this later. I'll be
grateful is somebody with better knowledge of texinfo checks my patch in
the meantime.

--
Regards,
Pavel Roskin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]