automake
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Warning fix for automake on CVS Libtool


From: Tom Tromey
Subject: Re: Warning fix for automake on CVS Libtool
Date: 05 May 2001 15:28:32 -0600

>>>>> "Pavel" == Pavel Roskin <address@hidden> writes:

Pavel>  * automake.in (scan_texinfo_file): Don't push undefined values
Pavel>  to @clean_suffixes.

Pavel> -        push @clean_suffixes, $predefined_index{$1};
Pavel> +        push @clean_suffixes, $predefined_index{$1}
Pavel> +          if (defined $predefined_index{$1});

I think any possible value here is already defined.
So the `if' is not required.

Maybe this was fixed after you sent your patch?  I don't see anything
in the ChangeLog though.

Pavel> -        push @clean_suffixes, $hidden_index{$1};
Pavel> +        push @clean_suffixes, $hidden_index{$1}
Pavel> +          if (defined $hidden_index{$1});

I think this is actually ok.

Akim, I notice that while @defcodeindex is handled, @defindex is not.
Is that intentional, or just an oversight?

Tom



reply via email to

[Prev in Thread] Current Thread [Next in Thread]