[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 118-lex-tests.patch

From: Akim Demaille
Subject: Re: 118-lex-tests.patch
Date: 08 May 2001 13:51:36 +0200
User-agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.1 (Cuyahoga Valley)

>>>>> "Tom" == Tom Tromey <address@hidden> writes:

>>>>> "Akim" == Akim Demaille <address@hidden> writes:
Akim> * (&handle_single_transform_list): Simplify
Akim> computation of $object and $this_obj_ext.  * tests/lex3.test:
Akim> Merge into...  * tests/lex.test: here.  * tests/pr19.test:
Akim> Improve and rename as...  * tests/lex3.test: this.

Tom> How about we agree not to remove tests, and only change them if
Tom> they are obviously, blatantly wrong?  I try to treat the test
Tom> suite as append-only as much as possible.  Changing them is just
Tom> asking for trouble.  Also it seems pointless: it doesn't
Tom> substantially help with long term maintenance of automake, nor
Tom> does it make useful progress towards a new release.

It looks like my answer never went out.

My point in changing some parts of the test suite is:

1. make it easier to move to another testing framework

2. group together related tests so that it is easier to see whether
   all the possibilities are covered (it is fairly common to have
   a pseudo Cartesian product of options to test, and having them
   split across several test files does not help improving the test

The cons is mainly that before knowing that foobar.test fails can be
enough to spot what is actually going wrong.  Now if foobar.test holds
several tests it is no longer doable.

But in practice we always need at least a VERBOSE run, so this point,
IMHO, does not hold.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]