[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Automake 1.4j: Release Candidate [PATCH]

From: Raja R Harinath
Subject: Re: Automake 1.4j: Release Candidate [PATCH]
Date: Tue, 31 Jul 2001 17:13:07 -0500
User-agent: Gnus/5.090004 (Oort Gnus v0.04) Emacs/21.0.103

Richard Boulton <address@hidden> writes:
> Removing the @parent_conds machinery and simply recursing through the
> conditional variables and taking all the possible conditional combinations
> makes sense to me, and works correctly as far as I can tell.  
> -     # If this condition cannot be true when the parent conditions
> -     # are true, then skip it.
> -     next
> -       if ! conditionals_true_when (@parent_conds, $vcond);
> -         next
> -           if ! conditionals_true_when (@parent_conds, $perm);

Since you kill the only two calls to 'conditionals_true_when', why not
kill 'conditionals_true_when' too :-)

- Hari
Raja R Harinath ------------------------------ address@hidden
"When all else fails, read the instructions."      -- Cahn's Axiom
"Our policy is, when in doubt, do the right thing."   -- Roy L Ash

reply via email to

[Prev in Thread] Current Thread [Next in Thread]