[Eric Blake <address@hidden>] Re: build question

[Tom Tromey]

A problem with line termination in automake was reported on the
Classpath list.  I don't understand why this happens, since in
Automake::XFile we only call binmode when writing, not when reading.

Any ideas from the Windows experts out there?

Tom
------- Start of forwarded message -------
Message-ID: <address@hidden>
Date: Sat, 09 Feb 2002 11:35:19 -0700
From: Eric Blake <address@hidden>
Organization: BYU Student
MIME-Version: 1.0
To: address@hidden
CC: Classpath list <address@hidden>
Subject: Re: build question
References: <address@hidden> <address@hidden>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=us-ascii

Tom Tromey wrote:
> 
> >>>>> "Eric" == Eric Blake <address@hidden> writes:
> 
> Eric> automake: native/jni/java-lang/Makefile.am: `\' is not a standard
> Eric> libtool library name
> 
> This is curious.  This error shouldn't happen.  Apparently what is
> happening here is that automake thinks that the `\' continuation
> character in the definition of pkglib_LTLIBRARIES is supposed to be
> the name of a library.
> 
> I can't reproduce this problem here.  Since you are using Cygwin,
> which most of us aren't, perhaps the problem is somehow related to
> that.  For instance, it could be a line termination problem.
> 
> Could you investigate this for me?  I'd like to fix automake.

It has to be line terminator translation somewhere, because this hack to
automake makes everything work for me.  I'm sure you could find a more
elegant way to fix the problem, and that the real fix should be upstream
in the sources rather than in the final executable; however, I'm not
familiar enough with the automake sources and/or perl to suggest a
better fix.

$ diff -u automake.bak automake
--- automake.bak        Sat Feb  9 10:35:42 2002
+++ automake    Sat Feb  9 11:31:48 2002
@@ -6455,6 +6455,7 @@

     while ($_ = $am_file->getline)
     {
+        s/\r\n/\n/g;
        if (/$IGNORE_PATTERN/o)
        {
            # Merely delete comments beginning with two hashes.
@@ -6498,6 +6499,7 @@
     # FIXME: shouldn't use $_ in this loop; it is too big.
     while ($_)
     {
+        s/\r\n/\n/g;
        $_ .= "\n"
            unless substr ($_, -1, 1) eq "\n";

-- 
This signature intentionally left boring.

Eric Blake             address@hidden
  BYU student, free software programmer

------- End of forwarded message -------