Re: Distcheck: cannot create regular file

[Alexandre Duret-Lutz]

>>> "Bruce" == Bruce Korb <address@hidden> writes:

[...]

 Bruce> Distributing files marked read-only or in read-only directories
 Bruce> really ought not cause a distribution failure.  

They really wouldn't cause distcheck failures if they weren't rebuilt.
(Does it ring a bell?)

[...]

 Bruce> This is a really gnarly little twisty hassle, but I
 Bruce> think I've simplified the issue as much as I know how.

I think we already discussed this, probably at the time the
"Conditional subdirectories" section was added to the manual.
I suggest you take a look at it, it's really much easier.

As long as LIBOPTS_DIRS is defined using a conditional, as you
do in libopts/MakeDefs.inc, then libopts/ will be distributed
correctly without any work from you.

The trouble, in blocksort, comes from the fact that LIBOPTS_DIR
is defined by an AC_SUBSTitution.  A bogus AC_SUBST, by the
way, because LIBOPTS_DIR was set to either '' or 'true' (i.e.,
never to 'libopts' which is what we would expect in SUBDIRS)

blocksort-1.4.2 passes distcheck with the following patch.

--- blocksort-1.4.2/Makefile.am 2003-02-15 20:22:55.000000000 +0100
+++ blocksort-1.4.2/Makefile.am 2003-02-16 02:37:10.000000000 +0100
@@ -16,10 +16,11 @@
 extra              = $(TARG)-lsm.tpl $(TARG)-spec.tpl bsort-opt.def
 specfiles          = $(TARG).lsm $(TARG).spec
 CFG_FILES          = cfg/libopts.m4 cfg/bootstrap cfg/bootstrap.local
-EXTRA_DIST         = $(specfiles) $(extra) $(TARG).1 $(CFG_FILES) libopts
+EXTRA_DIST         = $(specfiles) $(extra) $(TARG).1 $(CFG_FILES)
 man_MANS           = blocksort.1
 
+include $(srcdir)/libopts/MakeDefs.inc
 SUBDIRS            = $(LIBOPTS_DIR)
 blocksort_LDADD    = $(LIBOPTS_LDADD)
 blocksort_CFLAGS   = $(LIBOPTS_CFLAGS)
--- blocksort-1.4.2/cfg/libopts.m4      2003-02-15 20:23:14.000000000 +0100
+++ blocksort-1.4.2/cfg/libopts.m4      2003-02-16 02:27:50.000000000 +0100
@@ -337,7 +337,6 @@
   AM_CONDITIONAL([NEED_LIBOPTS], [test -n "${LIBOPTS_DIR}"])
   AC_SUBST(LIBOPTS_LDADD)
   AC_SUBST(LIBOPTS_CFLAGS)
-  AC_SUBST(LIBOPTS_DIR)
   AC_CONFIG_FILES([libopts/Makefile])
 ]) # end of AC_DEFUN of LIBOPTS_CHECK
--- blocksort-1.4.2/libopts/libopts.m4  2003-02-15 19:55:40.000000000 +0100
+++ blocksort-1.4.2/libopts/libopts.m4  2003-02-16 02:35:49.000000000 +0100
@@ -337,6 +337,5 @@
   AM_CONDITIONAL([NEED_LIBOPTS], [test -n "${LIBOPTS_DIR}"])
   AC_SUBST(LIBOPTS_LDADD)
   AC_SUBST(LIBOPTS_CFLAGS)
-  AC_SUBST(LIBOPTS_DIR)
   AC_CONFIG_FILES([libopts/Makefile])
 ]) # end of AC_DEFUN of LIBOPTS_CHECK


-- 
Alexandre Duret-Lutz