Re: GNU Automake 1.10.1 released -- bug #516 is still there

[Ralf Wildenhues]

Hello Peter,

* Peter Breitenlohner wrote on Tue, Jan 22, 2008 at 10:03:02AM CET:
>
> more than a year ago I filed a bug report (automake#516), after sending an
> email some month earlier:

There are lots of bugs that have not beed addressed before 1.10.1, some
are way older and more important than this one.  I've been spending
waaay too much of my time on Automake lately in the first place.  But
still, I simply forgot your bug in my latest sweep.  Sorry about that.


That being said, this is the original report:
<http://lists.gnu.org/archive/html/bug-automake/2006-10/msg00032.html>
It sounds like a rather obvious packaging bug in this case (why
distribute something you generate with config.status anyway?).

> automake generated Makefiles install manpages from the source tree in
> preference to those from the build tree
>
> together with a tiny and IMHO uncontroversial patch solving this problem.

At the time I looked at this back then, I wasn't sure the patch is
right.  The previous code looked to me like it did what it did for a
good reason.  But there is no explanation in the code, and I had not
done the history digging to find out whether it's on purpose or not.

I did take a look at history now, and think that your patch is ok, and
the order reversing just an oversight.  The patch is missing a ChangeLog
entry and a test.  Providing them would have saved me time processing
the bug.

> I am terribly disappointed that I never got any reaction and that this bug
> is still present in the new release.

And you've made that quite clear by spamming it to five lists instead of
to bug-automake as noted.  I've limited that to automake lists now.

Regards,
Ralf

    * lib/am/mans.am (install-man%SECTION%): Prefer generated manpages
    over distributed ones.
    Report and patch by Peter Breitenlohner.
    * tests/man3.test: New test.
    * tests/Makefile.am: Update.

diff --git a/lib/am/mans.am b/lib/am/mans.am
index b3e9053..4281254 100644
--- a/lib/am/mans.am
+++ b/lib/am/mans.am
@@ -1,5 +1,5 @@
 ## automake - create Makefile.in from Makefile.am
-## Copyright (C) 1998, 2001, 2003, 2004, 2006 Free Software Foundation, Inc.
+## Copyright (C) 1998, 2001, 2003, 2004, 2006, 2008 Free Software Foundation, 
Inc.
 
 ## This program is free software; you can redistribute it and/or modify
 ## it under the terms of the GNU General Public License as published by
@@ -42,8 +42,8 @@ install-man%SECTION%: $(man%SECTION%_MANS) $(man_MANS)
        done; \
        for i in $$list; do \
 ## Find the file.
-         if test -f $(srcdir)/$$i; then file=$(srcdir)/$$i; \
-         else file=$$i; fi; \
+         if test -f $$i; then file=$$i; \
+         else file=$(srcdir)/$$i; fi; \
 ## Change the extension if needed.
          ext=`echo $$i | sed -e 's/^.*\\.//'`; \
          case "$$ext" in \
diff --git a/tests/Makefile.am b/tests/Makefile.am
index db40acc..796a34d 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -371,6 +371,7 @@ makej.test \
 makevars.test \
 man.test \
 man2.test \
+man3.test \
 mclean.test \
 mdate.test \
 mdate2.test \
diff --git a/tests/Makefile.in b/tests/Makefile.in
index ceff3f4..219d4dd 100644
--- a/tests/Makefile.in
+++ b/tests/Makefile.in
@@ -520,6 +520,7 @@ makej.test \
 makevars.test \
 man.test \
 man2.test \
+man3.test \
 mclean.test \
 mdate.test \
 mdate2.test \
diff --git a/tests/man3.test b/tests/man3.test
new file mode 100755
index 0000000..2527e9c
--- /dev/null
+++ b/tests/man3.test
@@ -0,0 +1,44 @@
+#! /bin/sh
+# Copyright (C) 2008  Free Software Foundation, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3, or (at your option)
+# any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+# PR 516: Prefer generated manpages to distributed ones.
+
+. ./defs || exit 1
+
+set -e
+
+cat > Makefile.am << 'END'
+dist_man_MANS = foo.1
+installcheck-local:
+       grep bar "$(mandir)/man1/foo.1"
+END
+
+cat >>configure.in <<'END'
+: ${foo=foo}
+AC_SUBST([foo])
+AC_CONFIG_FILES([foo.1])
+AC_OUTPUT
+END
+
+cat > foo.1.in <<'END'
address@hidden@
+END
+
+$ACLOCAL
+$AUTOMAKE
+$AUTOCONF
+./configure
+$MAKE distcheck DISTCHECK_CONFIGURE_FLAGS=foo=bar