Re: GNU Automake 1.10.1 released

[Tim Rice]

Hello Ralf,

On Tue, 22 Jan 2008, Ralf Wildenhues wrote:

> Hello Tim,
> 
> * Tim Rice wrote on Tue, Jan 22, 2008 at 06:57:59PM CET:
> > On Tue, 22 Jan 2008, Ralf Wildenhues wrote:
> > 
> > > I'm pleased to announce the release of Automake 1.10.1.
> > 
> > Any reason this never made it in?
> >      http://lists.gnu.org/archive/html/bug-automake/2005-10/msg00016.html
> 
> Dunno, don't remember seeing that before.  Let's take a look:
> 
> | --- automake-1.9.6/lib/am/subdirs.am.old        2005-05-14 
> 13:21:06.000000000 -0700
> | +++ automake-1.9.6/lib/am/subdirs.am    2005-10-27 21:04:01.460314004 -0700
> | @@ -93,7 +93,7 @@
> |         esac; \
> |         rev=''; for subdir in $$list; do \
> |           if test "$$subdir" = "."; then :; else \
> | -           rev="$$subdir $$rev"; \
> | +           test -d "$$subdir"  &&  rev="$$subdir $$rev"; \
> |           fi; \
> |         done; \
> |  ## Always do `.' last.
> 
> 0) It needs a  s/  [ ]*/ /g.
> 
> 1) With some BSD make's,
>      test $CONDITION && $ACTION 
> 
>    makes `make' stop when the condition is false.  Solution is to use
>      test ! $CONDITION || $ACTION

Or, 

--- lib/am/subdirs.am.old       2008-01-21 14:11:41.000000000 -0800
+++ lib/am/subdirs.am   2008-01-22 15:16:05.207832004 -0800
@@ -91,7 +91,9 @@
        esac; \
        rev=''; for subdir in $$list; do \
          if test "$$subdir" = "."; then :; else \
-           rev="$$subdir $$rev"; \
+           if test -d "$$subdir"; then \
+             rev="$$subdir $$rev"; \
+           fi; \
          fi; \
        done; \
 ## Always do `.' last.
> 
> 2) If the above is applied, a 
>      make clean
> 
>    will not fail if some subdirectories are not present (though a
>    subsequent `make all' will).  I'm not sure if this is a problem;
>    I certainly don't think subdirectories get lost all that often,
>    but I have a habit of using `make clean' after $vcs update and
>    similar operations to find out if everything is still ok.
> 
> Have you encountered this in packages other than Libtool?  Asking
> because Libtool HEAD has this fixed.

I think I remember other packages having that problem but I've been
patching automake for so long I don't have a clue which ones.
If I remember correctly, it was when I did not use some feature that
was in its own subdir.
 
> Cheers, and thanks,
> Ralf
 
Thanks for reviewing it.

-- 
Tim Rice                                Multitalents    (707) 887-1469
address@hidden