[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch] restore original spacing width for verbose mode
From: |
Jan Engelhardt |
Subject: |
Re: [patch] restore original spacing width for verbose mode |
Date: |
Fri, 1 May 2009 18:46:42 +0200 (CEST) |
User-agent: |
Alpine 2.00 (LSU 1167 2008-08-23) |
On Friday 2009-05-01 09:57, Ralf Wildenhues wrote:
>Hi Jan,
>
>* Jan Engelhardt wrote on Thu, Apr 30, 2009 at 09:05:07PM CEST:
>> Output seems crushed, so restore the original behavior.
>
>Can you explain this, please?
The original submission I did around October 2008 followed the
Linux-style output, which happens to match /^ {2}.{7} .*/:
CC init/main.o
However with the reworking of the silent-rules patches, the
resulting output turned to /^ {2}.{6} .*/, which is not what
I had in mind, even if the longest string is currently OBJCLD.
And as such..
>> --- automake.orig/automake.in
>> +++ automake/automake.in
>> @@ -1199,7 +1199,7 @@ sub define_verbose_tagvar ($)
>> my ($name) = @_;
>> if (option 'silent-rules')
>> {
>> - define_verbose_var ($name, '@echo " '. $name . ' ' x (6 - length
>> ($name)) . '" $@;');
>> + define_verbose_var ($name, '@echo " '. $name . ' ' x (8 - length
>> ($name)) . '" $@;');
>> define_verbose_var ('at', '@');
>> }
>> }
this is what I changed to restore the behavior sought
originally (though it should have been 7, not 8).
>Also, can you please use automake-patches for patches?
Will do.