Re: "make dist" and "make distcheck" trouble

[Ralf Wildenhues]

* David Bruce wrote on Mon, Sep 28, 2009 at 01:08:58AM CEST:
> On 9/27/09, Ralf Wildenhues wrote:
> > * David Bruce wrote on Sat, Sep 26, 2009 at 04:51:01AM CEST:
> >> My project is not creating valid tarballs with "make dist", and "make
> >> distcheck" fails at the VPATH build stage.
> >
> > Please post your Makefile.am files in toplevel and src.  We might also
> > need to see your configure.ac file.
> 
> Thanks so much - here are the files, pasted inline.

Which Autoconf and Automake versions do you use?

> 1. toplevel Makefile.am:

> datadir = @datadir@

No need for this line, datadir is AC_SUBSTed from configure.ac.

> localedir = $(datadir)/locale

Likewise, this also gets a nonempty default from Automake 2.60 and
newer.

> ## These are defined in configure.ac:
> address@hidden@

You can also write $(NSIS) here, NSIS is also AC_SUBSTed.

> address@hidden@
> address@hidden@
> address@hidden@

These three lines shouldn't be needed.

> NSI_TEMP_INSTALL_DIR=$(abs_top_builddir)/_instw32

> ## 'dist_fonts' is in EXTRA_DATA but is empty by default.  With this target,

s/EXTRA_DATA/EXTRA_DIST/  ?

> ## 'dist_fonts' gets set to a list of the font files in data/fonts before 
> making
> ## 'dist', causing the fonts to be included in the tar.gz.
> ## 'data_fonts' should contain all of the fonts in data/fonts. It needs to go
> ## in this Makefile.am before the 'dist_with_fonts' target for that target
> ## to work - if it is in data/fonts/Makefile.am, it does not get expanded
> ## before the 'dist' target starts:

Please show data/fonts/Makefile.am, I bet the error is in there.

> data_fonts='AndikaDesRevG.ttf'
> dist_with_fonts:
>       $(MAKE) $(AM_MAKEFLAGS) distdir=$(PACKAGE)_w_fonts-$(VERSION) \
>            dist_fonts=$(data_fonts) dist
> dist_with_fonts_bzip2:
>       $(MAKE) $(AM_MAKEFLAGS) distdir=$(PACKAGE)_w_fonts-$(VERSION) \
>            dist_fonts=$(data_fonts) dist-bzip2

> install-nsi-local: all
[...]
> ## copy needed dll files into NSI_INSTALL_DIR:
>       -cp $(NSI_DLL_DIR)/*.dll $(top_builddir)/$(NSI_INSTALL_DIR);

Hmm; see below.


> clean-local:
>       @$(NORMAL_CLEAN)

What is $(NORMAL_CLEAN) ?

>       if test -d $(NSI_INSTALL_DIR); then \
>         rm -fr $(NSI_INSTALL_DIR); \
>       fi
>       if test -e address@hidden@-win32-installer.exe; then \
>         rm address@hidden@-win32-installer.exe; \
>       fi
> 
> .PHONY: nsis

> 2. src/Makefile.am:


> address@hidden@
> 
> # How to make an RC file
> tuxmathrc.o: tuxmathrc.rc
>       $(WINDRES) -i $< -o $@

$< in non-inferenecs rules is not portable to non-GNU make.  You can use
tuxmathrc.rc or $(srcdir)/tuxmathrc.rc (whichever is right for your
package) instead.

> (end of src/Makefile.am)
> 

> 3. configure.ac:


> NSI_DLL_DIR=~/tuxmath_dll

Tilde expansion is not portable.  This directory default seems quite
suspicious to me.

> AC_ARG_WITH([dll-directory],
>             AS_HELP_STRING([--with-dll-directory=path], [set the path
> where dll for TuxMath are [$(NSI_DLL_DIR)]]),

s/dll/the DLL/ ?  s/are/is/  ?  The language is a bit rough.

>             [dll_path=$withval],
>             [dll_path=no])
> 
> AM_CONDITIONAL(NSI_BUILD, test $dll_path = no)
> 
> if test $dll_path != no; then
> NSI_DLL_DIR=$dll_path
> fi
> AC_SUBST(NSI_DLL_DIR)

seems to not ever use the default path?

Cheers,
Ralf