[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: integration of perl with automake

From: Ralf Wildenhues
Subject: Re: integration of perl with automake
Date: Tue, 20 Oct 2009 08:27:01 +0200
User-agent: Mutt/1.5.20 (2009-08-09)

Hello Andreas,

thanks for sharing your solution.  A couple of comments:

* Andreas Otto wrote on Mon, Oct 19, 2009 at 12:20:26PM CEST:
> PERLMAKEFILE  = Net-Msgque/Makefile
> PERLDEPEND    = Net-Msgque/Makefile.PL Net-Msgque/typemap Net-
> Msgque/lib/Net/
> PERLCONFIG    =   PREFIX=$(prefix) \

It would be prudent to quote $(prefix), too.

>                   INC="-Wall -I. -I../$(top_srcdir)/src" \
>                   OBJECT="\$$(O_FILES) ../$(top_builddir)/src/.libs/*.o"

> install-exec-local:
>         cd Net-Msgque && $(MAKE) $(AM_MAKEFLAGS) DESTDIR=$(DESTDIR) install

Likewise, I'd quote $(DESTDIR) here, or even better, omit
DESTDIR=$(DESTDIR) unless Net-Msgque/Makefile initializes it.

> uninstall-local:
>         rm -f $(DESTDIR)/$(prefix)/lib/*/site_perl/*/*/Net/

Please remove the slash between $(DESTDIR) and $(prefix) here and in
following lines.  Otherwise you risk breaking the installation on w32
with --prefix=C:/foo and empty DESTDIR.  Also, again it would be prudent
to quote the $(DESTDIR)$(prefix) part of the strings.

>         rm -f 
> $(DESTDIR)/$(prefix)/lib/*/site_perl/*/*/auto/Net/Msgque/
>         rm -f 
> $(DESTDIR)/$(prefix)/lib/*/site_perl/*/*/auto/Net/Msgque/
>         rm -f 
> $(DESTDIR)/$(prefix)/lib/*/site_perl/*/*/auto/Net/Msgque/autosplit.ix
>         rm -f 
> $(DESTDIR)/$(prefix)/lib/*/site_perl/*/*/auto/Net/Msgque/.packlist
>         rm -f $(DESTDIR)/$(prefix)/lib/*/*/*/perllocal.pod
>         rm -f $(DESTDIR)/$(prefix)/share/man/man3/Net::Msgque.3
> distclean-local:
>         test -f Net-Msgque/.distclean && rm -fr Net-Msgque

Won't that also remove files from your package iff source and build tree


reply via email to

[Prev in Thread] Current Thread [Next in Thread]