automake
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

what happened to DIST_SOURCES:


From: Brian J. Murrell
Subject: what happened to DIST_SOURCES:
Date: Thu, 25 Mar 2010 13:30:59 -0400

We are seeing the following in trying to build our package(s) with some
versions of autoconf/automake:

libcfs/libcfs/autoMakefile.am:88: variable `DIST_SOURCES' is defined but no 
program or
libcfs/libcfs/autoMakefile.am:88: library has `DIST' as canonic name (possible 
typo)
lnet/klnds/ciblnd/autoMakefile.am:44: variable `DIST_SOURCES' is defined but no 
program or
lnet/klnds/ciblnd/autoMakefile.am:44: library has `DIST' as canonic name 
(possible typo)
lnet/klnds/gmlnd/autoMakefile.am:44: variable `DIST_SOURCES' is defined but no 
program or
lnet/klnds/gmlnd/autoMakefile.am:44: library has `DIST' as canonic name 
(possible typo)
...

Somebody has proposed a patch to simply move uses of DIST_SOURCES
assignments to EXTRA_DIST as such:

@@ -84,9 +84,7 @@ endif
 
 install-data-hook: $(install_data_hook)
 
-EXTRA_DIST := Info.plist
-
 MOSTLYCLEANFILES := @MOSTLYCLEANFILES@ linux-*.c linux/*.o darwin/*.o libcfs
-DIST_SOURCES := $(libcfs-all-objs:%.o=%.c) tracefile.h user-prim.c \
-                                           user-lock.c user-tcpip.c 
user-bitops.c\
-                                           user-mem.c linux/linux-tracefile.h
+EXTRA_DIST := $(libcfs-all-objs:%.o=%.c) Info.plist tracefile.h \
+       user-prim.c user-lock.c user-tcpip.c user-bitops.c      \
+       user-mem.c linux/linux-tracefile.h

But I can't help feeling like this is only a band-aid over the real
problem.

I wonder if somebody can help me understand what has happened to
DIST_SOURCES and how we should properly migrate towards it's successor.

Cheers and thanx,
b.


Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]