[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: files left in build directory after distclean

From: Peter Johansson
Subject: Re: files left in build directory after distclean
Date: Wed, 30 May 2012 10:11:06 +1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.4) Gecko/20120422 Thunderbird/10.0.4

On 05/30/2012 02:09 AM, Adam Mercer wrote:
On Wed, May 23, 2012 at 6:13 PM, Peter Johansson<address@hidden>  wrote:

For me distcheck complains about no sed file which is because you call it
'sed -f git_version.sed' while it should be 'sed -f
$(srcdir)/git_version.sed' as the sed script is distributed (in srcdir).
But the script copies git_version.sed to $(builddir), and updates it
if appropriate,

That doesn't happen:

[peterJo:~/tmp/foo-0.1]$ mkdir build
[peterJo:~/tmp/foo-0.1]$ cd build
[peterJo:~/tmp/foo-0.1/build]$ ../configure
checking for a BSD-compatible install... /usr/local/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /usr/local/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking for style of include used by make... GNU
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for gcc option to accept ISO C99... -std=gnu99
checking whether make supports nested variables... yes
checking for a Python interpreter with version >= 2.6... python
checking for python... /usr/bin/python
checking for python version... 2.6
checking for python platform... linux2
checking for python script directory... ${prefix}/lib/python2.6/site-packages checking for python extension module directory... ${exec_prefix}/lib64/python2.6/site-packages
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating config.h
config.status: executing depfiles commands
[peterJo:~/tmp/foo-0.1/build]$ make V=1
/usr/bin/python ../ .. $PWD
sed -f git_version.sed ../ > git_version.h.tmp
sed: couldn't open file git_version.sed: No such file or directory
make: *** [git_version.h] Error 4

so I want to use the version in $(builddir). Forcing
the use of the version in $(srcdir) could lead to incorrect version

To have files with same name in both builddir and srcdir is to ask for problems, IMHO. What happens if srcdir and builddir are the same?

If you wanna generate $(builddir)/git_version.sed, don't distribute it as well. Or distribute it (in $(srcdir)) and don't generate it in $(builddir). Or distribute it but let the generated have a slightly different name. Btw, is the distributed script ever used if you intend to generate one anyway?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]