Re: [bug-gettext] autopoint and m4_ifndef

[Sami Kerola]

On 24 July 2013 02:58, Daiki Ueno <address@hidden> wrote:
> Pavel Raiskup <address@hidden> writes:
>
>> Is there a reason why autopoint/gettextize is run before aclocal?
>
> One possible reason is that autopoint copies M4 files from a tarball
> (e.g. /usr/share/gettext/archive.dir.tar.*), rather than the standard
> aclocal directory.  They need to be processed by aclocal later.
>
>> (Other, quite long-term solution would be to hack aclocal to be able to
>> give us its *hardly built* list of include files, or used macros, e.g. by
>> some special option - ehm, but it may even more complicate the aclocal
>> code)
>
> Yeah, but I doubt that autopoint needs to trace macros defined outside
> of configure.ac.  Currently it traces only the following macros, which
> are usually invoked from configure.ac.
>
> AM_GNU_GETTEXT
> AM_GNU_GETTEXT_VERSION
> AC_CONFIG_AUX_DIR
> AC_CONFIG_MACRO_DIRS
> AC_CONFIG_MACRO_DIR
> AC_CONFIG_FILES

Would it be easiest for everyone to inform use of m4_fatal() may lead
to premature failures, and one should use AC_MSG_ERROR when possible.
For example util-linux would need following change.

diff --git a/configure.ac b/configure.ac
index 2ad890b..917e1fa 100644
--- a/configure.ac
+++ b/configure.ac
@@ -118,11 +118,11 @@ dnl libtool-2
 LT_INIT

 m4_ifndef([PKG_PROG_PKG_CONFIG],
-  [m4_fatal([Could not locate the pkg-config autoconf
+  [AC_MSG_ERROR([Could not locate the pkg-config autoconf
     macros. These are usually located in /usr/share/aclocal/pkg.m4.
     If your macros are in a different location, try setting the
     environment variable AL_OPTS="-I/other/macro/dir" before running
-    ./autogen.sh or autoreconf again.])])
+    ./autogen.sh or autoreconf again.], [1])])
 PKG_PROG_PKG_CONFIG

 GTK_DOC_CHECK([1.10])


And maybe there should be a AC_IFM4DEFINED([what], [true], [false])
for checks like that.

-- 
Sami Kerola
http://www.iki.fi/kerolasa/