[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] port elisp-compilation support to emacs-23.1 and newer

From: Jim Meyering
Subject: Re: [PATCH] port elisp-compilation support to emacs-23.1 and newer
Date: Mon, 27 Nov 2017 20:18:13 -0800

On Mon, Nov 27, 2017 at 8:12 PM, Jim Meyering <address@hidden> wrote:
> On Mon, Nov 27, 2017 at 12:52 PM, Jim Meyering <address@hidden> wrote:
>> On Mon, Nov 27, 2017 at 10:27 AM, Glenn Morris <address@hidden> wrote:
>>> Jim Meyering wrote:
>>>> In May of 2017, support for using the long-deprecated
>>>> byte-compile-dest-file function was removed, and that removal broke
>>>> automake's elisp-compiling rule for any .el file not in the current
>>>> directory.
>>> In general, Emacs expects .el and .elc to be found in the same
>>> directory. Not adhering to this convention will likely break various
>>> Emacs features. Is this really something automake needs to enable at all?
>> An alternative would be to copy-or-link the .el file into the
>> destination directory. Indeed. That would work without breaking pre-23
>> emacs, so I will adjust my automake patch before pushing it to master.
> Hi Glenn,
> I've thought about this some more and do not like the idea of
> requiring automake's elisp-compilation rule to make a copy of the
> source file in the destination directory in this slightly contrived
> case. Remember: this arises only in a non-srcdir build. That means
> build artifacts end up being written into the mostly-empty current
> directory hierarchy, which does not have copies of the sources.
> Installation processes will continue to copy both .el and .elc files
> into place.

Here is the updated (NEWS addition) patch that I expect to push to
master tomorrow. Feedback welcome. I will also delete the "micro"
branch I created.

Attachment: am-elisp-build-failure.diff
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]