[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Automake testsuite misuses DejaGnu

From: Jacob Bachmeyer
Subject: Re: Automake testsuite misuses DejaGnu
Date: Mon, 12 Jul 2021 17:53:51 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20090807 MultiZilla/ SeaMonkey/1.1.17 Mnenhy/

Karl Berry wrote:
DejaGnu has always required a DejaGnu testsuite to be rooted at a "testsuite" directory

If something was stated in the documentation, but not enforced by the
code, hardly surprising that "non-conformance" is widespread.

It is not widespread -- all of the toolchain packages correctly place their testsuites in testsuite/ directories. As far as I know, the Automake tests are the only outlier.

Anyway, it seems like an unfriendly requirement for users. And even more
to incompatibly enforce something now that has not been enforced for
previous decades. Why? (Just wondering.) -k

Previous versions of DejaGnu did not properly handle non-recursive make with Automake-produced makefiles. Beginning with 1.6.3, the testsuite is allowed to be in ${srcdir}/testsuite instead of ${srcdir} exactly. Enforcing the long-documented (and mostly followed) requirement that there be a directory named "testsuite" containing the testsuite allows DejaGnu to resolve the ambiguity and determine if it has been invoked at package top-level or in the testsuite/ directory directly.

Even in 1.6.3, there was intent to continue to allow the broken cases to work with a warning, but I made the conditional for that case too narrow (oops!) and some of the Automake test cases fail as a result. Fixing this now is appropriate because no one is going to see the future deprecation warnings due to the way Automake tests are run.

-- Jacob

reply via email to

[Prev in Thread] Current Thread [Next in Thread]