Re: bbdb fails with rmail on emacs 25 due to depreciated function rmail-narrow-to-non-pruned-header

[sokolgeo]

Thank you very much, your commit seem to work just fine!

http://git.savannah.nongnu.org/cgit/bbdb.git/commit/?id=2da950300bb22fa713cede74b71041df315ecc2e

For some reason I could not make git version under cygwin. Here is my 
error on 'make' step:

abs_target=`cygpath -w 
/home/gsokolsky/bbdb_install/bbdb/lisp/bbdb-loaddefs.el | sed 
's/\\\\/\\\\\\\\/g'`; \
emacs --batch --no-init-file --no-site-file  \
        --load autoload \
        --eval '(setq generated-autoload-file "'"$abs_target"'")' \
        --eval '(setq make-backup-files nil)' \
        --funcall batch-update-autoloads .
Opening output file: No such file or directory, 
/home/kbrown/src/cygemacs/emacs-25.3-1.x86_64/src/emacs-25.3/lisp/C:\cygwin64\home\gsokolsky\bbdb_install\bbdb\lisp\bbdb-loaddefs.el
make[2]: *** [Makefile:636: bbdb-loaddefs.el] Error 255
make[2]: Leaving directory '/home/gsokolsky/bbdb_install/bbdb/lisp'
make[1]: *** [Makefile:313: all] Error 2
make[1]: Leaving directory '/home/gsokolsky/bbdb_install/bbdb/lisp'
make: *** [Makefile:401: all-recursive] Error 1

So I just manually applied your commit to lisp files and byte-recompiled 
them.

Thank you very much for your help again!  Any chance new bbdb appearing 
on ELPA/MELPA any time soon?

George

-----Original Message-----
From: Roland Winkler [mailto:address@hidden
Sent: Donnerstag, 3. Mai 2018 05:54
To: address@hidden
Cc: address@hidden
Subject: Re: bbdb fails with rmail on emacs 25 due to depreciated 
function rmail-narrow-to-non-pruned-header

On Wed May 2 2018 address@hidden wrote:
> This is apparently happening in line 38 in bbdb-3.2\bbdb-rmail.el:
>
>        (with-no-warnings (rmail-narrow-to-non-pruned-header))
>
> I believe this is related to bug
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=556993
> I.e. GNU Emacs version 23 and above does not provide funciton
> rmail-narrow-to-non-pruned-header

Thanks for reporting.

The function rmail-narrow-to-non-pruned-header doesn't exist anymore
and the above debian bug report provided a patch for this.  Yet this
patch somehow disappeared again when BBDB was prepared for elpa.git.

I've installed a simplified patch.  Does it work now?