Re: error with bbdb-check-name

[Stefan Monnier]

> I think there's indeed a problem because `cl-lib` is not `require`d.
> IOW, I think we need something like the patch below,

Or even the one below,


        Stefan


diff --git a/bbdb-com.el b/bbdb-com.el
index 3d13c14f4..5e5a5d85e 100644
--- a/bbdb-com.el
+++ b/bbdb-com.el
@@ -181,6 +181,8 @@ With prefix ARG a negative number, do not invert next 
search."
   (bbdb-prefix-message))
 
 (defmacro bbdb-search (records &rest spec)
+  ;; FIXME: Provide a functionsl-interface so client code can be compiled
+  ;; without having BBDB around!
   "Search RECORDS for fields matching SPEC.
 The following keywords are supported in SPEC to search fields in RECORDS
 matching the regexps RE:
diff --git a/bbdb-migrate.el b/bbdb-migrate.el
index 0270c7219..6b196df61 100644
--- a/bbdb-migrate.el
+++ b/bbdb-migrate.el
@@ -37,6 +37,7 @@
 
 ;;; Code:
 
+(require 'cl-lib)
 (require 'bbdb)
 
 ;;; Migrating the BBDB
diff --git a/bbdb-mua.el b/bbdb-mua.el
index 671a45ebe..455900eb9 100644
--- a/bbdb-mua.el
+++ b/bbdb-mua.el
@@ -1,6 +1,6 @@
 ;;; bbdb-mua.el --- various MUA functionality for BBDB -*- lexical-binding: t 
-*-
 
-;; Copyright (C) 2010-2018  Free Software Foundation, Inc.
+;; Copyright (C) 2010-2020  Free Software Foundation, Inc.
 
 ;; This file is part of the Insidious Big Brother Database (aka BBDB),
 
@@ -240,7 +240,7 @@ Usually this function is called by the wrapper 
`bbdb-mua-update-records'."
   ;; with the chain `bbdb-mua-auto-update-p' -> `bbdb-select-message'
   ;; -> `bbdb-update-records-p'.
   (while (and (functionp update-p)
-              ;; Bad! `search' is a function in `cl-seq.el'.
+              ;; Bad! `search' is a function in `cl.el'.
               (not (eq update-p 'search)))
     (setq update-p (funcall update-p)))
   (cond ((eq t update-p)
diff --git a/bbdb-tex.el b/bbdb-tex.el
index fbdf95b2d..c3c156aa7 100644
--- a/bbdb-tex.el
+++ b/bbdb-tex.el
@@ -1,6 +1,6 @@
 ;;; bbdb-tex.el --- feed BBDB into LaTeX  -*- lexical-binding: t -*-
 
-;; Copyright (C) 2010-2017  Free Software Foundation, Inc.
+;; Copyright (C) 2010-2020  Free Software Foundation, Inc.
 
 ;; Authors: Boris Goldowsky <boris@cs.rochester.edu>
 ;;          Dirk Grunwald <grunwald@cs.colorado.edu>
@@ -103,6 +103,7 @@
 
 ;;; Code:
 
+(eval-when-compile (require 'cl-lib))
 (require 'bbdb)
 (require 'bbdb-com)
 
diff --git a/bbdb.el b/bbdb.el
index 05967ecdb..051b21d09 100644
--- a/bbdb.el
+++ b/bbdb.el
@@ -37,6 +37,7 @@
 
 ;;; Code:
 
+(eval-when-compile (require 'cl-lib))
 (require 'timezone)
 (require 'bbdb-site)